Skip to content

Default MetricValue special members #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyskov-ai wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

Default MetricValue special members #684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aece10a
Default MetricValue special members
lyskov-ai May 1, 2026
e91f32a
Fix -Werror=unused-parameter on defaulted MetricValue copy constructor
lyskov-ai May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/src/basic/MetricValue.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@ class MetricValueBase : public utility::VirtualBase {
public:
// note: MetricValueBase must have a virtual function so that it will be polymorphic
// (specifically to allow dynamic casting)
~MetricValueBase() override {};
~MetricValueBase() override = default;
virtual MetricValueBaseOP clone() const = 0;
};


template <class T>
class MetricValue : public MetricValueBase {
public:
MetricValue() {};
MetricValue( MetricValue const & metric_value ) : MetricValueBase(), data_(metric_value.value()) {};
MetricValue() = default;
MetricValue( MetricValue const & ) = default;
MetricValue( T const & inp ) : data_(inp) {};
void set( T const & inp ) { data_ = inp; };
std::string print() const { std::ostringstream ostream; ostream << data_; return ostream.str(); };
Expand Down