Modernize copy prevention in core factory singletons and non-copyable classes#685
Open
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Open
Modernize copy prevention in core factory singletons and non-copyable classes#685lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
lyskov-ai wants to merge 1 commit intoRosettaCommons:mainfrom
Conversation
… classes SilentStructFactory, ConstraintFactory, and SequenceFactory all inherit from SingletonBase, which already = delete's copy construction and copy assignment. Remove the now-redundant private unimplemented declarations from each derived class. OrbitalsStatistics and AtomTreeDiff had private-but-undefined copy constructors (pre-C++11 idiom); replace with explicit = delete on both copy constructor and copy assignment.
lyskov
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
utility::SingletonBase, which already= deletes copy construction and copy assignment. Removes the now-redundant private-but-unimplemented declarations from each derived class (pre-C++11 idiom).= deleteon both copy constructor and copy assignment operator.No behaviour change; build-only verification is sufficient for pure copy-prevention modernisation.
Test plan
scons.py -j16 mode=debug)