Skip to content

Apply Rule of Zero to core signal event hierarchies #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lyskov-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Apply Rule of Zero to core signal event hierarchies #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions source/src/core/conformation/signals/ConnectionEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,30 +86,7 @@ struct ConnectionEvent { // do not derive from GeneralEvent
{}


/// @brief copy constructor
inline
ConnectionEvent( ConnectionEvent const & rval ) :
conformation( rval.conformation ),
tag( rval.tag )
{}


/// @brief default destructor
inline
virtual
~ConnectionEvent() {}


/// @brief copy assignment
inline
ConnectionEvent &
operator =( ConnectionEvent const & rval ) {
if ( this != &rval ) {
conformation = rval.conformation;
tag = rval.tag;
}
return *this;
}
virtual ~ConnectionEvent() = default;


/// @brief the Conformation firing the signal
Expand Down
23 changes: 1 addition & 22 deletions source/src/core/conformation/signals/GeneralEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,28 +59,7 @@ struct GeneralEvent {
{}


/// @brief copy constructor
inline
GeneralEvent( GeneralEvent const & rval ) :
conformation( rval.conformation )
{}


/// @brief default destructor
inline
virtual
~GeneralEvent() {}


/// @brief copy assignment
inline
GeneralEvent &
operator =( GeneralEvent const & rval ) {
if ( this != &rval ) {
conformation = rval.conformation;
}
return *this;
}
virtual ~GeneralEvent() = default;


/// @brief the Conformation firing the signal
Expand Down
29 changes: 0 additions & 29 deletions source/src/core/conformation/signals/IdentityEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,35 +84,6 @@ struct IdentityEvent : public GeneralEvent {
{}


/// @brief copy constructor
inline
IdentityEvent( IdentityEvent const & rval ) :
Super( rval ),
tag( rval.tag ),
position( rval.position ),
residue( rval.residue )
{}


/// @brief default destructor
inline
~IdentityEvent() override {}


/// @brief copy assignment
inline
IdentityEvent &
operator =( IdentityEvent const & rval ) {
if ( this != &rval ) {
Super::operator =( rval );
tag = rval.tag;
position = rval.position;
residue = rval.residue;
}
return *this;
}


/// @brief tag indicating type of identity change
Tag tag;

Expand Down
23 changes: 0 additions & 23 deletions source/src/core/conformation/signals/XYZEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,29 +59,6 @@ struct XYZEvent : public GeneralEvent {
{}


/// @brief copy constructor
inline
XYZEvent( XYZEvent const & rval ) :
Super( rval )
{}


/// @brief copy assignment
inline
XYZEvent &
operator =( XYZEvent const & rval ) {
if ( this != &rval ) {
Super::operator =( rval );
}
return *this;
}


/// @brief default destructor
inline
~XYZEvent() override {}


};


Expand Down
23 changes: 0 additions & 23 deletions source/src/core/pose/signals/ConformationEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,29 +57,6 @@ struct ConformationEvent : public GeneralEvent {
{}


/// @brief copy constructor
inline
ConformationEvent( ConformationEvent const & rval ) :
Super( rval )
{}


/// @brief default destructor
inline
~ConformationEvent() override {}


/// @brief copy assignment
inline
ConformationEvent &
operator =( ConformationEvent const & rval ) {
if ( this != &rval ) {
Super::operator =( rval );
}
return *this;
}


};


Expand Down
23 changes: 1 addition & 22 deletions source/src/core/pose/signals/DestructionEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,28 +49,7 @@ struct DestructionEvent { // do not derive from GeneralEvent
{}


/// @brief copy constructor
inline
DestructionEvent( DestructionEvent const & rval ) :
pose( rval.pose )
{}


/// @brief default destructor
inline
virtual
~DestructionEvent() {}


/// @brief copy assignment
inline
DestructionEvent &
operator =( DestructionEvent const & rval ) {
if ( this != &rval ) {
pose = rval.pose;
}
return *this;
}
virtual ~DestructionEvent() = default;


/// @brief the Pose firing the signal
Expand Down
23 changes: 0 additions & 23 deletions source/src/core/pose/signals/EnergyEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,29 +56,6 @@ struct EnergyEvent : public GeneralEvent {
{}


/// @brief copy constructor
inline
EnergyEvent( EnergyEvent const & rval ) :
Super( rval )
{}


/// @brief default destructor
inline
~EnergyEvent() override {}


/// @brief copy assignment
inline
EnergyEvent &
operator =( EnergyEvent const & rval ) {
if ( this != &rval ) {
Super::operator =( rval );
}
return *this;
}


};


Expand Down
23 changes: 1 addition & 22 deletions source/src/core/pose/signals/GeneralEvent.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,7 @@ struct GeneralEvent {
{}


/// @brief copy constructor
inline
GeneralEvent( GeneralEvent const & rval ) :
pose( rval.pose )
{}


/// @brief default destructor
inline
virtual
~GeneralEvent() {}


/// @brief copy assignment
inline
GeneralEvent &
operator =( GeneralEvent const & rval ) {
if ( this != &rval ) {
pose = rval.pose;
}
return *this;
}
virtual ~GeneralEvent() = default;


/// @brief the Pose firing the signal
Expand Down