Skip to content

Commit d395d8d

Browse files
tridgeclaude
andcommitted
ci: clean up workflow shellcheck nits
actionlint (rhysd/actionlint) reported a handful of shellcheck-class issues across the GitHub Actions workflows. All are 1-line mechanical fixes: * Replace legacy backticks in --rsync-bin=`pwd`/rsync with --rsync-bin="$PWD/rsync" (SC2006 + SC2046; almalinux-8-build, macos-build, ubuntu-22.04-build, ubuntu-build). * Quote >>$GITHUB_PATH redirects as >>"$GITHUB_PATH" (SC2086; coverage, macos-build, ubuntu-22.04-build, ubuntu-build). After this commit `actionlint .github/workflows/*.yml` exits 0. (Also cleaned up 6 editor backup *.yml~ files from the local working tree; those weren't tracked -- *~ is gitignored -- so the cleanup is local-only and not part of this commit.) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 14d6c29 commit d395d8d

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

.github/workflows/almalinux-8-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
run: RSYNC_EXPECT_SKIPPED=crtimes,daemon-access-ip,daemon-chroot-acl,proxy-response-line-too-long make check
6666
- name: check (TCP daemon transport)
6767
# Second run exercising the real loopback-TCP daemon path.
68-
run: ./runtests.py --rsync-bin=`pwd`/rsync --use-tcp -j 8
68+
run: ./runtests.py --rsync-bin="$PWD/rsync" --use-tcp -j 8
6969
- name: ssl file list
7070
run: ./rsync-ssl --no-motd download.samba.org::rsyncftp/ || true
7171
- name: save artifact

.github/workflows/coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
run: |
2828
sudo apt-get update
2929
sudo apt-get install -y acl libacl1-dev attr libattr1-dev liblz4-dev libzstd-dev libxxhash-dev python3-cmarkgfm openssl gcovr
30-
echo "/usr/local/bin" >>$GITHUB_PATH
30+
echo "/usr/local/bin" >>"$GITHUB_PATH"
3131
- name: configure
3232
run: ./configure --enable-coverage --with-rrsync
3333
- name: make

.github/workflows/macos-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
run: |
2727
brew install automake openssl xxhash zstd lz4
2828
pip3 install --user --break-system-packages commonmark
29-
echo "$(brew --prefix)/bin" >>$GITHUB_PATH
29+
echo "$(brew --prefix)/bin" >>"$GITHUB_PATH"
3030
- name: configure
3131
run: |
3232
BREW_PREFIX=$(brew --prefix)
@@ -48,7 +48,7 @@ jobs:
4848
- name: check (TCP daemon transport)
4949
# Second run with daemon tests over a real loopback rsyncd; the default
5050
# 'make check' above uses the secure stdio-pipe transport.
51-
run: sudo ./runtests.py --rsync-bin=`pwd`/rsync --use-tcp -j 8
51+
run: sudo ./runtests.py --rsync-bin="$PWD/rsync" --use-tcp -j 8
5252
- name: ssl file list
5353
run: rsync-ssl --no-motd download.samba.org::rsyncftp/ || true
5454
- name: save artifact

.github/workflows/ubuntu-22.04-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
- name: prep
3030
run: |
3131
sudo apt-get install acl libacl1-dev attr libattr1-dev liblz4-dev libzstd-dev libxxhash-dev python3-cmarkgfm openssl
32-
echo "/usr/local/bin" >>$GITHUB_PATH
32+
echo "/usr/local/bin" >>"$GITHUB_PATH"
3333
- name: configure
3434
run: ./configure --with-rrsync
3535
- name: make
@@ -47,7 +47,7 @@ jobs:
4747
- name: check (TCP daemon transport)
4848
# Second run with daemon tests over a real loopback rsyncd; the default
4949
# 'make check' above uses the secure stdio-pipe transport.
50-
run: sudo ./runtests.py --rsync-bin=`pwd`/rsync --use-tcp -j 8
50+
run: sudo ./runtests.py --rsync-bin="$PWD/rsync" --use-tcp -j 8
5151
- name: ssl file list
5252
run: rsync-ssl --no-motd download.samba.org::rsyncftp/ || true
5353
- name: save artifact

.github/workflows/ubuntu-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- name: prep
2626
run: |
2727
sudo apt-get install acl libacl1-dev attr libattr1-dev liblz4-dev libzstd-dev libxxhash-dev python3-cmarkgfm openssl
28-
echo "/usr/local/bin" >>$GITHUB_PATH
28+
echo "/usr/local/bin" >>"$GITHUB_PATH"
2929
- name: configure
3030
run: ./configure --with-rrsync
3131
- name: make
@@ -45,7 +45,7 @@ jobs:
4545
# 'make check' above uses the secure stdio-pipe transport (no listening
4646
# sockets); this run exercises the real TCP accept/auth path. Skip-set
4747
# is env-dependent here (chroot-acl), so leave RSYNC_EXPECT_SKIPPED unset.
48-
run: sudo ./runtests.py --rsync-bin=`pwd`/rsync --use-tcp -j 8
48+
run: sudo ./runtests.py --rsync-bin="$PWD/rsync" --use-tcp -j 8
4949
- name: ssl file list
5050
run: rsync-ssl --no-motd download.samba.org::rsyncftp/ || true
5151
- name: save artifact

0 commit comments

Comments
 (0)