-
Notifications
You must be signed in to change notification settings - Fork 16
SplitPane: collapse state + onCollapse double-click #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
packages/core/src/layout/__tests__/splitPaneCollapse.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import { assert, describe, test } from "@rezi-ui/testkit"; | ||
| import type { VNode } from "../../index.js"; | ||
| import { layout } from "../layout.js"; | ||
|
|
||
| function mustLayout(vnode: VNode, maxW: number, maxH: number) { | ||
| const res = layout(vnode, 0, 0, maxW, maxH, "column"); | ||
| if (!res.ok) { | ||
| assert.fail(`layout failed: ${res.fatal.code}: ${res.fatal.detail}`); | ||
| } | ||
| return res.value; | ||
| } | ||
|
|
||
| describe("splitPane collapse", () => { | ||
| test("collapsed index forces panel to minSize (default 0)", () => { | ||
| const sp = { | ||
| kind: "splitPane", | ||
| props: { | ||
| id: "sp", | ||
| direction: "horizontal", | ||
| sizes: Object.freeze([50, 50]), | ||
| onResize: () => {}, | ||
| collapsible: true, | ||
| collapsed: Object.freeze([0]), | ||
| }, | ||
| children: Object.freeze([ | ||
| { kind: "divider", props: {} }, | ||
| { kind: "divider", props: {} }, | ||
| ]), | ||
| } as unknown as VNode; | ||
|
|
||
| const tree = mustLayout(sp, 100, 10); | ||
| const c0 = tree.children[0]; | ||
| const c1 = tree.children[1]; | ||
| assert.ok(c0 !== undefined && c1 !== undefined); | ||
| if (!c0 || !c1) return; | ||
|
|
||
| // dividerSize default = 1, so panel widths must sum to 99. | ||
| assert.equal(c0.rect.w, 0); | ||
| assert.equal(c1.rect.x, 1); | ||
| assert.equal(c1.rect.w, 99); | ||
| }); | ||
|
|
||
| test("collapsed index uses provided minSizes[index]", () => { | ||
| const sp = { | ||
| kind: "splitPane", | ||
| props: { | ||
| id: "sp", | ||
| direction: "horizontal", | ||
| sizes: Object.freeze([50, 50]), | ||
| minSizes: Object.freeze([10, 0]), | ||
| onResize: () => {}, | ||
| collapsible: true, | ||
| collapsed: Object.freeze([0]), | ||
| }, | ||
| children: Object.freeze([ | ||
| { kind: "divider", props: {} }, | ||
| { kind: "divider", props: {} }, | ||
| ]), | ||
| } as unknown as VNode; | ||
|
|
||
| const tree = mustLayout(sp, 100, 10); | ||
| const c0 = tree.children[0]; | ||
| const c1 = tree.children[1]; | ||
| assert.ok(c0 !== undefined && c1 !== undefined); | ||
| if (!c0 || !c1) return; | ||
|
|
||
| assert.equal(c0.rect.w, 10); | ||
| assert.equal(c1.rect.x, 11); | ||
| assert.equal(c1.rect.w, 89); | ||
| }); | ||
|
|
||
| test("collapsed list is ignored when collapsible is false", () => { | ||
| const sp = { | ||
| kind: "splitPane", | ||
| props: { | ||
| id: "sp", | ||
| direction: "horizontal", | ||
| sizes: Object.freeze([50, 50]), | ||
| onResize: () => {}, | ||
| collapsible: false, | ||
| collapsed: Object.freeze([0]), | ||
| }, | ||
| children: Object.freeze([ | ||
| { kind: "divider", props: {} }, | ||
| { kind: "divider", props: {} }, | ||
| ]), | ||
| } as unknown as VNode; | ||
|
|
||
| const tree = mustLayout(sp, 100, 10); | ||
| const c0 = tree.children[0]; | ||
| const c1 = tree.children[1]; | ||
| assert.ok(c0 !== undefined && c1 !== undefined); | ||
| if (!c0 || !c1) return; | ||
|
|
||
| assert.ok(c0.rect.w > 0, "panel should not be collapsed when collapsible=false"); | ||
| assert.ok(c1.rect.w > 0); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This records a double-click candidate on every divider mouse-down, but that state is not cleared when the interaction turns into a drag, so a quick second resize attempt on the same divider (within 500ms) is interpreted as a double-click and fires
onCollapseunexpectedly. In collapsible panes this causes unintended panel collapse during rapid consecutive drag adjustments; the double-click tracker should be invalidated on drag/mouse-up or armed only for click-like interactions.Useful? React with 👍 / 👎.