Remove in-repo ink-compat package and mark compatibility as redesign WIP#37
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e8da3f591
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "packages/core", | ||
| "packages/node", | ||
| "packages/testkit", | ||
| "packages/ink-compat", | ||
| "packages/native", | ||
| "packages/jsx", | ||
| "packages/bench", |
There was a problem hiding this comment.
Refresh lockfile when dropping ink-compat workspace
Removing the packages/ink-compat workspace here without regenerating package-lock.json leaves a stale workspace link (node_modules/@rezi-ui/ink-compat resolved to packages/ink-compat), but that directory is deleted in this commit; after install, imports of @rezi-ui/ink-compat used by benchmark scenarios fail with MODULE_NOT_FOUND because the symlink target does not exist. Please update the lockfile (or dependency wiring) in the same change so clean installs resolve a real package.
Useful? React with 👍 / 👎.
Summary
packages/ink-compatpackage from this branchpackages/ink-compatREADME.mdcompatibility messaging to state Ink compatibility is being redesigned and will return only after stronger validationNotes
/home/k3nig/Rezidirty working branch; work was done in a separate worktree branch frommain