Style merge hardening: cache safety and deterministic coverage#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mergeTextStyle()default-base boolean cache by freezing cached entries before storage/return, preventing shared-cache mutation poisoningpackages/core/src/renderer/__tests__/style.merge-cache.test.ts(13 tests) for key uniqueness, churn/staleness resistance, tri-state separation, new attrs, and cache hit-rate behaviorpackages/core/src/widgets/__tests__/style.merge-fuzz.test.ts(11 tests, 1024+ iterations per test, seeded RNG only)packages/core/src/widgets/__tests__/style.inheritance.test.ts(16 tests) covering Root->Box->Row->Text precedence, deep chains, and recompute-after-unset behaviorpackages/core/src/widgets/__tests__/style.utils.test.ts(6 tests) formergeStyles/styleWhencontractsdocs/guide/text-style-internals.mdwith cache audit notes and baseline lock metadataWhy
This hardens style merge correctness on the renderer hot path while increasing deterministic regression coverage for cache behavior, merge correctness, and inheritance semantics without adding new style features.
Validation
npm run lintnpm run buildnpm run typechecknode scripts/run-tests.mjs(2534passing,0failing)