docs: comprehensive documentation overhaul#88
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e7062c02c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ```ts | ||
| ui.grid({ columns: "auto 1fr auto", gap: 1 }, [ | ||
| ui.text("Label:"), | ||
| ui.input("name-input", { value: state.name, onChange: (v) => app.update({ name: v }) }), |
There was a problem hiding this comment.
Fix Input example to use supported callback signature
The Grid docs include ui.input("name-input", { value: state.name, onChange: ... }), but ui.input only accepts (id, value, props?) or a single InputProps object, and InputProps uses onInput (not onChange) (packages/core/src/widgets/ui.ts and packages/core/src/widgets/types.ts). As written, this example fails type-checking and, if copied into untyped code, passes a non-string value that triggers runtime prop validation errors, so readers following this snippet will hit a broken integration path immediately.
Useful? React with 👍 / 👎.
Summary
Scope
README.md,docs/**,mkdocs.yml, docs overrides/stylesheets).packages/**.Review Focus