create-rezi: flagship polished dashboard template + dashboard-only scaffolding#95
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 462df1f40e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (raw.key === 81 || raw.key === 113 || raw.key === 67 || raw.key === 99) { | ||
| stopDashboardAction(); | ||
| } |
There was a problem hiding this comment.
Remove app.stop calls from onEvent handlers
Calling stopDashboardAction() from app.onEvent causes app.stop() to run while createApp is inside an event handler, which violates stop()'s reentrancy guard (assertNotReentrant) and throws ZRUI_REENTRANT_CALL; in normal usage this path is hit by quit inputs (q/Ctrl+C), so the dashboard can enter a fatal error path instead of shutting down cleanly.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 8160b2c: shutdown now uses requestDashboardStop() which defers app.stop() via setTimeout(0) and deduplicates stop requests. This avoids reentrant stop() calls from onEvent/key handlers.
Summary
dashboardstarter as the flagshipcreate-rezitemplatecreate-rezitemplate catalog dashboard-only for now (dashboard, aliasdash)form-app,file-browser,streaming-viewer)Notes
create-rezi+ docs.Validation
npm run buildnpm run check:create-rezi-templatesnpm run check:docs