🐛 Fix slowly loading task list when navigating from settings page (RubberDuckCrew#299)

Author: IamPekka058

lib/core/task_handler.dart

@@ -19,6 +19,15 @@ class TaskHandler extends ChangeNotifier {
 
   List<IssueLabel> _repoLabels = [];
 
+  bool _tasksLoading = false;
+  bool _labelsLoading = false;
+
+  /// Whether the task handler is currently loading task data.
+  bool get tasksLoading => _tasksLoading;
+
+  /// Whether the task handler is currently loading label data.
+  bool get labelsLoading => _labelsLoading;
+
   /// The list of all tasks available in the repository.
   List<Task> get tasks => List.unmodifiable(_tasks);
 
@@ -28,11 +37,14 @@ class TaskHandler extends ChangeNotifier {
   /// The list of all tasks available in the repository.
   /// After the notification the current list of task is stored in [tasks].
   Future<void> loadTasks() async {
+    _tasksLoading = true;
+    notifyListeners();
     try {
       final RepositoryDetails? repo = await SettingsHandler()
           .getSelectedRepository();
       if (repo == null) {
         Logger.logWarning("No repository selected", _classId);
+        _tasksLoading = false;
         return;
       }
       final List<Task> issues = await _fetchIssuesForRepository(repo);
@@ -49,13 +61,16 @@ class TaskHandler extends ChangeNotifier {
       Logger.logError("Failed to load tasks", _classId, e);
     } finally {
       Logger.logInfo("Loaded ${_tasks.length} tasks from repository", _classId);
+      _tasksLoading = false;
       notifyListeners();
     }
   }
 
   /// The list of all labels available in the repository.
   /// After the notification the current list of labels is stored in [repoLabels].
   Future<void> loadLabels() async {
+    _labelsLoading = true;
+    notifyListeners();
     try {
       _repoLabels.clear();
       final RepositoryDetails? repo = await SettingsHandler()
@@ -71,9 +86,11 @@ class TaskHandler extends ChangeNotifier {
         "Loaded ${_repoLabels.length} labels from repository ${repo.toSlug()}",
         _classId,
       );
-      notifyListeners();
     } on Exception catch (e) {
       Logger.logError("Failed to load labels", _classId, e);
+    } finally {
+      _labelsLoading = false;
+      notifyListeners();
     }
   }
 

lib/ui/main_screen.dart

@@ -20,11 +20,10 @@ class _MainScreenState extends State<MainScreen> {
     child: Consumer<MainScreenViewModel>(
       builder: (final context, final viewModel, final child) => Scaffold(
         appBar: const NormalAppBar(),
-        body: switch (viewModel.selectedIndex) {
-          0 => const TaskListView(),
-          1 => const SettingsView(),
-          _ => const TaskListView(),
-        },
+        body: IndexedStack(
+          index: viewModel.selectedIndex,
+          children: const [TaskListView(), SettingsView()],
+        ),
         bottomNavigationBar: NavigationBar(
           destinations: const [
             NavigationDestination(icon: Icon(Icons.inbox), label: "Todos"),

lib/ui/settings/widgets/repository_selector/repository_selector_view_model.dart

@@ -1,5 +1,6 @@
 import "package:flutter/material.dart";
 import "package:gitdone/core/models/repository_details.dart";
+import "package:gitdone/core/task_handler.dart";
 import "package:gitdone/ui/settings/widgets/repository_selector/repository_selector_model.dart";
 
 /// ViewModel for managing the state of the repository selector widget.
@@ -11,6 +12,7 @@ class RepositorySelectorViewModel extends ChangeNotifier {
       ..getAllUserRepositories()
       ..loadLocalRepository();
   }
+  final TaskHandler _taskHandler = TaskHandler();
   final RepositorySelectorModel _model = RepositorySelectorModel();
 
   /// The list of repositories available for selection.
@@ -22,5 +24,8 @@ class RepositorySelectorViewModel extends ChangeNotifier {
   /// Selects a repository and saves it to local storage.
   void selectRepository(final RepositoryDetails? repo) {
     _model.selectRepository(repo);
+    _taskHandler
+      ..loadTasks()
+      ..loadLabels();
   }
 }

lib/ui/task_list/task_list_view_model.dart

@@ -62,7 +62,6 @@ class TaskListViewModel extends ChangeNotifier {
   /// The current sort order applied to the task list.
   String _sort = defaultSort;
   bool _isEmpty = false;
-  bool _loading = true;
 
   static const _classId =
       "com.GitDone.gitdone.ui.task_edit.task_list_view_model";
@@ -80,7 +79,7 @@ class TaskListViewModel extends ChangeNotifier {
   bool get isEmpty => _isEmpty;
 
   /// Whether the task list is currently loading.
-  bool get isLoading => _loading;
+  bool get isLoading => _taskHandler.tasksLoading;
 
   /// Returns a list of FilterChipItems for all labels, reflecting current selection state.
   List<FilterChipItem<String>> get labelFilterChipItems => allLabels.isNotEmpty
@@ -132,11 +131,8 @@ class TaskListViewModel extends ChangeNotifier {
 
   /// The current search query used to filter tasks.
   Future<void> loadTasks() async {
-    _loading = true;
-    notifyListeners();
     await _taskHandler.loadTasks();
     _isEmpty = _taskHandler.tasks.isEmpty;
-    _loading = false;
     notifyListeners();
   }