Skip to content

Commit 2ed1576

Browse files
authored
update readme and fix CI problem with .NET SDK version (#103)
1 parent f629bf4 commit 2ed1576

10 files changed

Lines changed: 457 additions & 423 deletions

File tree

.editorconfig

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,3 +209,8 @@ dotnet_naming_symbols.private_internal_fields.applicable_kinds = field
209209
dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal
210210
dotnet_naming_style.camel_case_underscore_style.required_prefix = _
211211
dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case
212+
213+
# To avoid the scrollbar on the github homepage
214+
[Tutorial.cs]
215+
max_line_length = 100
216+
indent_size = 2

.github/workflows/linux-build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
- name: Install libgts
2222
run: sudo apt-get update && sudo apt-get install -y libgts-0.7-5
2323

24-
- name: Setup .NET
25-
uses: actions/setup-dotnet@v3
24+
- name: Setup .NET SDK
25+
uses: actions/setup-dotnet@v4
2626
with:
27-
dotnet-version: 8.0.x
27+
dotnet-version: '8.0.x'
2828

2929
- name: Setup Just
3030
uses: extractions/setup-just@v3

.github/workflows/nuget.org-linux.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ jobs:
2222
- name: Install libgts
2323
run: sudo apt-get update && sudo apt-get install -y libgts-0.7-5
2424

25-
- name: Setup .NET
26-
uses: actions/setup-dotnet@v3
25+
- name: Setup .NET SDK
26+
uses: actions/setup-dotnet@v4
2727
with:
28-
dotnet-version: 8.0.x
28+
dotnet-version: '8.0.x'
2929

3030
- name: Setup Just
3131
uses: extractions/setup-just@v3

.github/workflows/nuget.org-windows.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ jobs:
1717
with:
1818
fetch-depth: 0
1919

20+
- name: Setup .NET SDK
21+
uses: actions/setup-dotnet@v4
22+
with:
23+
dotnet-version: '8.0.x'
24+
2025
- name: Add msbuild to PATH
2126
uses: microsoft/setup-msbuild@v1.0.2
2227

.github/workflows/win-build.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# This is a basic workflow to help you get started with Actions
2-
31
name: win-build
42

53
# Controls when the action will run. Triggers the workflow on push or pull request
@@ -21,6 +19,11 @@ jobs:
2119
with:
2220
fetch-depth: 0
2321

22+
- name: Setup .NET SDK
23+
uses: actions/setup-dotnet@v4
24+
with:
25+
dotnet-version: '8.0.x'
26+
2427
- name: Add msbuild to PATH
2528
uses: microsoft/setup-msbuild@v1.0.2
2629

README-src.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,19 @@ Graphviz.NetWrapper
55

66
`Rubjerg.Graphviz` ships with precompiled Graphviz binaries to ensure the exact graphviz version is used that we have tested and to make deployment more predictable.
77
The current version we ship is Graphviz 11.0.0.
8-
9-
### Windows
10-
`Rubjerg.Graphviz` ships with a bunch of precompiled Graphviz dlls built for 64 bit Windows.
118
This library is compatible with .NET Standard 2.0, but the nuget package only supports .NET5.0 and higher.
129
The unit tests run on windows and linux against .NET Framework .NET 8.0.
1310

11+
### Windows
12+
`Rubjerg.Graphviz` ships with the necessary Graphviz binaries and dependencies built for 64 bit Windows.
13+
1414
### Linux
15-
In the same vein as our windows build, we ship precompiled binaries to make sure that this library is deployed with the same binaries as we've tested it.
16-
However, we do not ship graphviz dependencies, you will have to installed those yourself, if you need them.
15+
In the same vein as our windows build, we ship Graphviz binaries to make sure that this library is deployed with the same binaries as we've tested it.
16+
However, we do not ship all the dependencies of Graphviz.
17+
You will have to make sure these are available on your system, if you need them.
1718
[Here is a list of all the graphviz dependencies.](https://packages.fedoraproject.org/pkgs/graphviz/graphviz/fedora-rawhide.html#dependencies)
1819
In practice you may not need all of those.
19-
In particular, if you only want to read graphs and e.g. run the DOT algorithm, libc and libz are enough.
20+
In particular, if you only want to read graphs and run the DOT layout algorithm, libc and libz are enough.
2021
To run our tests successfully you will also need libgts and libpcre2 (for the neato algorithm).
2122
For more details, check the dependencies of any graphviz binaries with `ldd`.
2223

README.md

Lines changed: 213 additions & 207 deletions
Large diffs are not rendered by default.

Rubjerg.Graphviz.Test/Tutorial.cs

Lines changed: 206 additions & 201 deletions
Large diffs are not rendered by default.

global.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"sdk": {
3+
"version": "8.0.0",
4+
"rollForward": "latestFeature"
5+
}
6+
}

justfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,5 +82,8 @@ check-diff:
8282
check-fixme:
8383
bash -c "! git grep 'FIX''NOW'"
8484

85-
check-all: generate-readme normalize format check-diff check-fixme
85+
check-tutorial-width:
86+
awk 'length($0) > 100 { print FILENAME ":" NR ": " $0; found=1 } END { exit found }' Rubjerg.Graphviz.Test/Tutorial.cs
87+
88+
check-all: generate-readme normalize format check-diff check-fixme check-tutorial-width
8689

0 commit comments

Comments
 (0)