Skip to content

Commit e80ed94

Browse files
authored
chore: bump version to 1.2.0 (#6)
* chore: bump version to 1.2.0 * chore: run luacheck on pull requests * chore: split CI and release into separate workflows * fix: resolve luacheck warnings
1 parent 9d65db1 commit e80ed94

5 files changed

Lines changed: 29 additions & 8 deletions

File tree

.github/workflows/ci.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
pull_request:
8+
9+
jobs:
10+
lint:
11+
runs-on: ubuntu-latest
12+
13+
steps:
14+
- uses: actions/checkout@v4
15+
16+
- name: Run Luacheck
17+
uses: nebularg/actions-luacheck@v1
18+
with:
19+
annotate: warning

.github/workflows/release.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
1-
name: CI
1+
name: Release
22

33
on:
44
push:
5-
branches:
6-
- main
75
tags:
86
- "v*"
97

108
jobs:
11-
build:
9+
release:
1210
runs-on: ubuntu-latest
1311

1412
steps:
@@ -22,7 +20,6 @@ jobs:
2220
annotate: warning
2321

2422
- name: Package and Release
25-
if: startsWith(github.ref, 'refs/tags/')
2623
uses: BigWigsMods/packager@v2
2724
env:
2825
GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }}

.luacheckrc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,18 @@
11
std = "lua51"
22
max_line_length = false
33

4+
ignore = {
5+
"211/AddonName", -- unused variable: idiomatic WoW pattern (local AddonName, CT = ...)
6+
"212/self", -- unused argument: WoW callbacks always receive self; closures use it implicitly
7+
"432/self", -- shadowing upvalue: nested WoW callbacks each receive their own self
8+
}
9+
410
-- Globals set by this addon
511
globals = {
612
"CooldownTrackerDB",
713
"SLASH_COOLDOWNTRACKER1",
814
"SLASH_COOLDOWNTRACKER2",
15+
"SlashCmdList", -- addon writes SlashCmdList["COOLDOWNTRACKER"]
916
}
1017

1118
-- WoW API globals (read-only from this addon's perspective)
@@ -18,7 +25,6 @@ read_globals = {
1825
"SOUNDKIT",
1926
"UIParent",
2027
"GameTooltip",
21-
"SlashCmdList",
2228
-- Namespaces
2329
"C_Timer",
2430
"Settings",

CooldownTracker.toc

100644100755
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
## Title: Healer Cooldown Tracker
33
## Notes: Manually track healer cooldowns for raid leaders. Click to start a timer when a healer calls out on comms.
44
## Author: Reube
5-
## Version: 1.1.0
5+
## Version: 1.2.0
66
## SavedVariables: CooldownTrackerDB
77

88
Data.lua

UI.lua

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ end
5353
-- These functions reanchor all child widgets inside an existing row frame.
5454
-- ---------------------------------------------------------------------------
5555
local function ApplyWideLayout(row)
56-
local cd = row.cd
5756
local rowW = WIDE_W - 16
5857

5958
row:SetSize(rowW, WIDE_ROW_H)

0 commit comments

Comments
 (0)