diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..5c0c617 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,19 @@ +name: CI + +on: + push: + branches: + - main + pull_request: + +jobs: + lint: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v4 + + - name: Run Luacheck + uses: nebularg/actions-luacheck@v1 + with: + annotate: warning diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fa228a0..26f45a9 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -1,14 +1,12 @@ -name: CI +name: Release on: push: - branches: - - main tags: - "v*" jobs: - build: + release: runs-on: ubuntu-latest steps: @@ -22,7 +20,6 @@ jobs: annotate: warning - name: Package and Release - if: startsWith(github.ref, 'refs/tags/') uses: BigWigsMods/packager@v2 env: GITHUB_OAUTH: ${{ secrets.GITHUB_TOKEN }} diff --git a/.luacheckrc b/.luacheckrc index c8e171b..c8dfc69 100644 --- a/.luacheckrc +++ b/.luacheckrc @@ -1,11 +1,18 @@ std = "lua51" max_line_length = false +ignore = { + "211/AddonName", -- unused variable: idiomatic WoW pattern (local AddonName, CT = ...) + "212/self", -- unused argument: WoW callbacks always receive self; closures use it implicitly + "432/self", -- shadowing upvalue: nested WoW callbacks each receive their own self +} + -- Globals set by this addon globals = { "CooldownTrackerDB", "SLASH_COOLDOWNTRACKER1", "SLASH_COOLDOWNTRACKER2", + "SlashCmdList", -- addon writes SlashCmdList["COOLDOWNTRACKER"] } -- WoW API globals (read-only from this addon's perspective) @@ -18,7 +25,6 @@ read_globals = { "SOUNDKIT", "UIParent", "GameTooltip", - "SlashCmdList", -- Namespaces "C_Timer", "Settings", diff --git a/CooldownTracker.toc b/CooldownTracker.toc old mode 100644 new mode 100755 index 0f2f2c0..f47e6c9 --- a/CooldownTracker.toc +++ b/CooldownTracker.toc @@ -2,7 +2,7 @@ ## Title: Healer Cooldown Tracker ## Notes: Manually track healer cooldowns for raid leaders. Click to start a timer when a healer calls out on comms. ## Author: Reube -## Version: 1.1.0 +## Version: 1.2.0 ## SavedVariables: CooldownTrackerDB Data.lua diff --git a/UI.lua b/UI.lua index 33b5902..44fc84a 100755 --- a/UI.lua +++ b/UI.lua @@ -53,7 +53,6 @@ end -- These functions reanchor all child widgets inside an existing row frame. -- --------------------------------------------------------------------------- local function ApplyWideLayout(row) - local cd = row.cd local rowW = WIDE_W - 16 row:SetSize(rowW, WIDE_ROW_H)