Since random is no longer guaranteed to be actually "random", catch infinite loops for built-in point generation

Author: RudyTheDev

SharpVoronoiLib/GlobalUsings.cs

@@ -1,4 +1,5 @@
 // Global using directives
 
 global using System.Runtime.CompilerServices;
-global using JetBrains.Annotations;
+global using JetBrains.Annotations;
+global using SharpVoronoiLib.Exceptions;

SharpVoronoiLib/Point Generation/RandomGaussianPointGeneration.cs

@@ -16,6 +16,8 @@ protected override double GetNextRandomValue(IRandomNumberGenerator random, doub
 
         double mid = (max + min) / 2;
 
+        int safetyCounter = 0;
+        
         do
         {
             double u1 = 1.0 - random.NextDouble(); //uniform(0,1] random doubles
@@ -31,6 +33,10 @@ protected override double GetNextRandomValue(IRandomNumberGenerator random, doub
             if (coord > min && coord < max)
                 return coord;
 
+            safetyCounter++;
+            
+            if (safetyCounter > 100) throw new VoronoiRandomPointGenerationEncounteredTooManyInvalidSites();
+
         } while (true);
     }
 

SharpVoronoiLib/Point Generation/RandomPointGeneration.cs

@@ -1,6 +1,4 @@
-using SharpVoronoiLib.Exceptions;
-
-namespace SharpVoronoiLib;
+namespace SharpVoronoiLib;
 
 internal abstract class RandomPointGeneration : IPointGenerationAlgorithm
 {

SharpVoronoiLib/Point Generation/RandomUniformPointGeneration.cs

@@ -9,12 +9,18 @@ protected override void Prepare(IRandomNumberGenerator random, double minX, doub
 
     protected override double GetNextRandomValue(IRandomNumberGenerator random, double min, double max, int index, ValuePurpose valuePurpose)
     {
+        int safetyCounter = 0;
+        
         do
         {
             double value = min + random.NextDouble() * (max - min);
 
             if (value > min && value < max)
                 return value;
+
+            safetyCounter++;
+            
+            if (safetyCounter > 100) throw new VoronoiRandomPointGenerationEncounteredTooManyInvalidSites();
 
         } while (true);
     }

SharpVoronoiLib/Voronoi/VoronoiSite.cs

@@ -1,6 +1,4 @@
-using SharpVoronoiLib.Exceptions;
-
-namespace SharpVoronoiLib;
+namespace SharpVoronoiLib;
 
 /// <summary>
 /// The point/site/seed on the Voronoi plane.

SharpVoronoiLib/VoronoiPlane.cs

@@ -1,6 +1,4 @@
-using SharpVoronoiLib.Exceptions;
-
-namespace SharpVoronoiLib;
+namespace SharpVoronoiLib;
 
 /// <summary>
 /// An Euclidean plane where a Voronoi diagram can be constructed from <see cref="VoronoiSite"/>s