Skip to content

Commit 2d2b0b8

Browse files
committed
[MOD] #285 액티비티 kotlin ext -> viewBinding 변경
1 parent d62b22f commit 2d2b0b8

3 files changed

Lines changed: 25 additions & 23 deletions

File tree

app/src/main/java/com/runnect/runnect/presentation/draw/DrawActivity.kt

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ import com.runnect.runnect.data.dto.SearchResultEntity
4141
import com.runnect.runnect.data.dto.UploadLatLng
4242
import com.runnect.runnect.databinding.ActivityDrawBinding
4343
import com.runnect.runnect.databinding.BottomsheetRequireCourseNameBinding
44+
import com.runnect.runnect.databinding.CustomDialogMakeCourseBinding
4445
import com.runnect.runnect.presentation.MainActivity
4546
import com.runnect.runnect.presentation.countdown.CountDownActivity
4647
import com.runnect.runnect.presentation.state.UiState
@@ -54,8 +55,6 @@ import com.runnect.runnect.util.extension.setActivityDialog
5455
import com.runnect.runnect.util.extension.showToast
5556
import com.runnect.runnect.util.multipart.ContentUriRequestBody
5657
import dagger.hilt.android.AndroidEntryPoint
57-
import kotlinx.android.synthetic.main.custom_dialog_make_course.view.btn_run
58-
import kotlinx.android.synthetic.main.custom_dialog_make_course.view.btn_storage
5958
import kotlinx.coroutines.delay
6059
import kotlinx.coroutines.launch
6160
import timber.log.Timber
@@ -502,15 +501,14 @@ class DrawActivity : BindingActivity<ActivityDrawBinding>(R.layout.activity_draw
502501
* 코스 완성 시 뜨는 팝업 (보관함 가기 / 바로 달리기)
503502
*/
504503
private fun notifyCreateFinish() { //todo dialogFragment로 리팩토링
504+
val binding = CustomDialogMakeCourseBinding.inflate(layoutInflater)
505505
val (dialog, dialogLayout) = setActivityDialog(
506506
layoutInflater = layoutInflater,
507-
view = binding.root,
508-
resId = R.layout.custom_dialog_make_course,
507+
binding = binding,
509508
cancel = false
510509
)
511-
512-
with(dialogLayout) {
513-
this.btn_run.setOnClickListener {
510+
with(binding) {
511+
btnRun.setOnClickListener {
514512
Analytics.logClickedItemEvent(EventName.EVENT_CLICK_RUN_AFTER_COURSE_COMPLETE)
515513
if (isCustomLocationMode) departureLatLng = customDepartureLatLng
516514

@@ -539,7 +537,7 @@ class DrawActivity : BindingActivity<ActivityDrawBinding>(R.layout.activity_draw
539537
dialog.dismiss()
540538
}
541539

542-
this.btn_storage.setOnClickListener {
540+
btnStorage.setOnClickListener {
543541
Analytics.logClickedItemEvent(EventName.EVENT_CLICK_STORED_AFTER_COURSE_COMPLETE)
544542
val intent = Intent(this@DrawActivity, MainActivity::class.java).apply {
545543
putExtra(EXTRA_FRAGMENT_REPLACEMENT_DIRECTION, "fromDrawCourse")

app/src/main/java/com/runnect/runnect/presentation/mypage/history/MyHistoryActivity.kt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import android.app.AlertDialog
44
import android.content.ContentValues
55
import android.content.Intent
66
import android.os.Bundle
7+
import android.view.LayoutInflater
78
import android.view.View
89
import androidx.activity.OnBackPressedCallback
910
import androidx.activity.viewModels
@@ -13,6 +14,7 @@ import com.runnect.runnect.R
1314
import com.runnect.runnect.binding.BindingActivity
1415
import com.runnect.runnect.data.dto.HistoryInfoDTO
1516
import com.runnect.runnect.databinding.ActivityMyHistoryBinding
17+
import com.runnect.runnect.databinding.CustomDialogDeleteBinding
1618
import com.runnect.runnect.presentation.mypage.history.adapter.MyHistoryAdapter
1719
import com.runnect.runnect.presentation.mypage.history.detail.MyHistoryDetailActivity
1820
import com.runnect.runnect.presentation.search.SearchActivity
@@ -25,7 +27,6 @@ import com.runnect.runnect.util.extension.navigateToPreviousScreenWithAnimation
2527
import com.runnect.runnect.util.extension.setCustomDialog
2628
import com.runnect.runnect.util.extension.setDialogButtonClickListener
2729
import dagger.hilt.android.AndroidEntryPoint
28-
import kotlinx.android.synthetic.main.custom_dialog_delete.btn_delete_yes
2930
import timber.log.Timber
3031

3132
@AndroidEntryPoint
@@ -65,18 +66,18 @@ class MyHistoryActivity : BindingActivity<ActivityMyHistoryBinding>(R.layout.act
6566
}
6667

6768
private fun initDialog() {
69+
val binding = CustomDialogDeleteBinding.inflate(layoutInflater)
6870
dialog = setCustomDialog(
69-
layoutInflater = layoutInflater,
70-
view = binding.root,
71+
binding = binding,
7172
description = DIALOG_DESC,
7273
yesBtnText = DELETE_BTN
7374
)
7475
}
7576

76-
private fun setDialogClickEvent() {
77-
dialog.setDialogButtonClickListener { which ->
77+
private fun setDialogClickEvent(binding: CustomDialogDeleteBinding) {
78+
dialog.setDialogButtonClickListener(binding) { which ->
7879
when (which) {
79-
dialog.btn_delete_yes -> viewModel.deleteHistory()
80+
binding.btnDeleteYes -> viewModel.deleteHistory()
8081
}
8182
}
8283
}
@@ -111,7 +112,8 @@ class MyHistoryActivity : BindingActivity<ActivityMyHistoryBinding>(R.layout.act
111112

112113
private fun handleDeleteButtonClicked(it: View) {
113114
if (it.isEnabled) {
114-
setDialogClickEvent()
115+
val binding = CustomDialogDeleteBinding.inflate(LayoutInflater.from(it.context))
116+
setDialogClickEvent(binding)
115117
dialog.show()
116118
}
117119
}

app/src/main/java/com/runnect/runnect/presentation/mypage/upload/MyUploadActivity.kt

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import androidx.recyclerview.widget.GridLayoutManager
1414
import com.runnect.runnect.R
1515
import com.runnect.runnect.binding.BindingActivity
1616
import com.runnect.runnect.databinding.ActivityMyUploadBinding
17+
import com.runnect.runnect.databinding.CustomDialogDeleteBinding
1718
import com.runnect.runnect.presentation.detail.CourseDetailActivity
1819
import com.runnect.runnect.presentation.detail.CourseDetailRootScreen
1920
import com.runnect.runnect.presentation.discover.DiscoverFragment
@@ -31,8 +32,6 @@ import com.runnect.runnect.util.extension.setCustomDialog
3132
import com.runnect.runnect.util.extension.setDialogButtonClickListener
3233
import com.runnect.runnect.util.extension.showSnackbar
3334
import dagger.hilt.android.AndroidEntryPoint
34-
import kotlinx.android.synthetic.main.custom_dialog_delete.btn_delete_no
35-
import kotlinx.android.synthetic.main.custom_dialog_delete.btn_delete_yes
3635
import timber.log.Timber
3736

3837
@AndroidEntryPoint
@@ -41,6 +40,7 @@ class MyUploadActivity : BindingActivity<ActivityMyUploadBinding>(R.layout.activ
4140
private val viewModel: MyUploadViewModel by viewModels()
4241
private lateinit var uploadAdapter: MyUploadAdapter
4342
private lateinit var dialog: AlertDialog
43+
private lateinit var dialogBinding: CustomDialogDeleteBinding
4444

4545
private val resultLauncher =
4646
registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { result ->
@@ -135,23 +135,25 @@ class MyUploadActivity : BindingActivity<ActivityMyUploadBinding>(R.layout.activ
135135
}
136136
}
137137

138+
138139
private fun initDialog() {
140+
dialogBinding = CustomDialogDeleteBinding.inflate(layoutInflater)
139141
dialog = setCustomDialog(
140-
layoutInflater, binding.root,
141-
DESCRIPTION_DIALOG,
142-
DELETE_BTN
142+
binding = dialogBinding,
143+
description = DESCRIPTION_DIALOG,
144+
yesBtnText = DELETE_BTN
143145
)
144146
}
145147

146148
private fun setDialogClickEvent() {
147-
dialog.setDialogButtonClickListener { which ->
149+
dialog.setDialogButtonClickListener(dialogBinding) { which ->
148150
when (which) {
149-
dialog.btn_delete_yes -> {
151+
dialogBinding.btnDeleteYes -> {
150152
viewModel.deleteUploadCourse()
151153
dialog.dismiss()
152154
}
153155

154-
dialog.btn_delete_no -> {
156+
dialogBinding.btnDeleteNo -> {
155157
dialog.dismiss()
156158
}
157159
}

0 commit comments

Comments
 (0)