Skip to content

Commit 59a7da7

Browse files
committed
[Fix] #265 - 수정하는 닉네임이 중복일때 예외처리
1 parent 794a550 commit 59a7da7

2 files changed

Lines changed: 16 additions & 13 deletions

File tree

Runnect-iOS/Runnect-iOS/Presentation/MyPage/VC/MyPageVC.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -487,7 +487,7 @@ extension MyPageVC {
487487
self.showNetworkFailureToast()
488488
}
489489
case .failure(let error):
490-
print(error.localizedDescription)
490+
print("🍀🍀🍀\(error.localizedDescription)")
491491
self.showNetworkFailureToast()
492492
}
493493
}

Runnect-iOS/Runnect-iOS/Presentation/MyPage/VC/NicknameEditorVC.swift

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -107,11 +107,6 @@ extension NicknameEditorVC {
107107
self.navigationController?.popViewController(animated: true)
108108
}
109109

110-
@objc private func didNicknameReturn() {
111-
guard let nickname = nickNameTextField.text else { return }
112-
self.updateUserNickname(nickname: nickname)
113-
}
114-
115110
@objc private func textFieldTextDidChange() {
116111
guard let text = nickNameTextField.text else { return }
117112

@@ -123,8 +118,9 @@ extension NicknameEditorVC {
123118
}
124119

125120
@objc private func finishEditNickname() {
126-
didNicknameReturn()
127-
self.navigationController?.popViewController(animated: false)
121+
guard let nickname = nickNameTextField.text else { return }
122+
123+
self.updateUserNickname(nickname: nickname)
128124
}
129125
}
130126

@@ -184,6 +180,15 @@ extension NicknameEditorVC: UITextFieldDelegate {
184180

185181
extension NicknameEditorVC {
186182
func updateUserNickname(nickname: String) {
183+
184+
guard nickname != self.currentNickname else {
185+
print("💪 닉네임 변경 시도 전에 현재 닉네임과 동일한지 검사 성공 처리")
186+
// self.delegate?.nicknameEditDidSuccess()
187+
// 닉네임 같은데 굳이 또 서버 요청을 할 필요가 있나?
188+
self.navigationController?.popViewController(animated: false)
189+
return
190+
}
191+
187192
LoadingIndicator.showLoading()
188193
userProvider.request(.updateUserNickname(nickname: nickname)) { [weak self] response in
189194
LoadingIndicator.hideLoading()
@@ -193,15 +198,13 @@ extension NicknameEditorVC {
193198
let status = result.statusCode
194199
if 200..<300 ~= status {
195200
self.delegate?.nicknameEditDidSuccess()
196-
self.dismiss(animated: false)
197-
}
198-
if status >= 400 {
199-
print("400 error")
201+
self.navigationController?.popViewController(animated: false)
202+
} else {
200203
self.showNetworkFailureToast()
201204
}
202205
case .failure(let error):
206+
self.showToast(message: "중복된 닉네임입니다.")
203207
print(error.localizedDescription)
204-
self.showNetworkFailureToast()
205208
}
206209
}
207210
}

0 commit comments

Comments
 (0)