feat: add .golangci.yml config and fix all lint issues

Add golangci-lint v2 config with sensible linters for a CLI project
(gosec, revive, gocritic, errorlint, noctx, etc.) and fix all 9
issues found: use errors.As for wrapped errors, avoid range copy of
large structs, replace http.Get with context-aware request, rename
shadowed builtin, and fix gofmt alignment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: chris-anstey-runware

.golangci.yml

@@ -0,0 +1,77 @@
+version: "2"
+
+linters:
+  enable:
+    # Bugs & correctness
+    - bodyclose
+    - nilerr
+    - nilnesserr
+    - noctx
+    - durationcheck
+    - copyloopvar
+    - errorlint
+
+    # Security
+    - gosec
+
+    # Style & clarity
+    - revive
+    - gocritic
+    - misspell
+    - unconvert
+    - unparam
+    - nakedret
+    - goconst
+    - predeclared
+    - usestdlibvars
+    - whitespace
+
+    # Performance
+    - intrange
+
+  settings:
+    gosec:
+      excludes:
+        - G115  # uintptr->int for term.IsTerminal is standard
+        - G117  # Marshaling API key to config file is intentional
+        - G301  # 0755 for output dirs is fine for a CLI
+        - G304  # File paths from variables are expected in a CLI
+
+    revive:
+      rules:
+        - name: blank-imports
+        - name: context-as-argument
+        - name: dot-imports
+        - name: error-return
+        - name: error-strings
+        - name: increment-decrement
+        - name: indent-error-flow
+        - name: range
+        - name: receiver-naming
+        - name: time-naming
+        - name: var-declaration
+        - name: var-naming
+
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - performance
+      disabled-checks:
+        - hugeParam
+
+    nakedret:
+      max-func-lines: 20
+
+    goconst:
+      min-len: 3
+      min-occurrences: 4
+
+formatters:
+  enable:
+    - gofmt
+
+  exclusions:
+    paths:
+      - "third_party$"
+      - "builtin$"
+      - "examples$"

cmd/account.go

@@ -37,11 +37,11 @@ var accountCreditsCmd = &cobra.Command{
 		format := output.ParseFormat(getFormat())
 
 		data := map[string]interface{}{
-			"balance":    result.Balance,
-			"today":      result.Usage.Today,
-			"last_7d":    result.Usage.Last7Days,
-			"last_30d":   result.Usage.Last30Days,
-			"total":      result.Usage.Total,
+			"balance":  result.Balance,
+			"today":    result.Usage.Today,
+			"last_7d":  result.Usage.Last7Days,
+			"last_30d": result.Usage.Last30Days,
+			"total":    result.Usage.Total,
 		}
 
 		return output.Print(format, data,

cmd/image_inference.go

@@ -335,7 +335,11 @@ func encodeImageFile(path string) (string, error) {
 
 // downloadImage downloads a URL to a local file.
 func downloadImage(url, destPath string) error {
-	resp, err := http.Get(url) //nolint:gosec // URL comes from API response
+	req, err := http.NewRequestWithContext(context.Background(), http.MethodGet, url, nil)
+	if err != nil {
+		return fmt.Errorf("failed to create request: %w", err)
+	}
+	resp, err := http.DefaultClient.Do(req)
 	if err != nil {
 		return fmt.Errorf("failed to download: %w", err)
 	}

cmd/model_search.go

@@ -89,7 +89,8 @@ func runModelSearch(cmd *cobra.Command, args []string) error {
 
 	headers := []interface{}{"AIR", "Name", "Category", "Arch", "Version"}
 	var rows [][]interface{}
-	for _, m := range result.Results {
+	for i := range result.Results {
+		m := &result.Results[i]
 		name := truncate(m.Name, 45)
 		rows = append(rows, []interface{}{m.AIR, name, m.Category, m.Architecture, m.Version})
 	}
@@ -102,10 +103,10 @@ func runModelSearch(cmd *cobra.Command, args []string) error {
 	return nil
 }
 
-func truncate(s string, max int) string {
+func truncate(s string, maxLen int) string {
 	s = strings.ReplaceAll(s, "\n", " ")
-	if len(s) <= max {
+	if len(s) <= maxLen {
 		return s
 	}
-	return s[:max-3] + "..."
+	return s[:maxLen-3] + "..."
 }

cmd/ping.go

@@ -41,8 +41,8 @@ var pingCmd = &cobra.Command{
 
 		format := output.ParseFormat(getFormat())
 		data := map[string]interface{}{
-			"status":     "ok",
-			"latency_ms": latencyMs,
+			"status":      "ok",
+			"latency_ms":  latencyMs,
 			"environment": env,
 		}
 

cmd/video_inference.go

@@ -271,14 +271,14 @@ func runVideoInference(cmd *cobra.Command, args []string) error {
 	if noDownload {
 		headers := []interface{}{"#", "URL", "Seed"}
 		var rows [][]interface{}
-		for i, r := range results {
-			url := r.VideoURL
+		for i := range results {
+			url := results[i].VideoURL
 			if url == "" {
-				url = r.MediaURL
+				url = results[i].MediaURL
 			}
-			row := []interface{}{i + 1, url, r.Seed}
+			row := []interface{}{i + 1, url, results[i].Seed}
 			if includeCost {
-				row = append(row, fmt.Sprintf("%.4f", r.Cost))
+				row = append(row, fmt.Sprintf("%.4f", results[i].Cost))
 			}
 			rows = append(rows, row)
 		}
@@ -299,27 +299,27 @@ func runVideoInference(cmd *cobra.Command, args []string) error {
 	}
 	var rows [][]interface{}
 
-	for i, r := range results {
+	for i := range results {
 		ext := outputFormat
 		if ext == "" {
 			ext = "mp4"
 		}
 		filename := fmt.Sprintf("runware_%s_%d.%s", time.Now().Format("20060102_150405"), i+1, ext)
 		destPath := filepath.Join(outputDir, filename)
 
-		url := r.VideoURL
+		url := results[i].VideoURL
 		if url == "" {
-			url = r.MediaURL
+			url = results[i].MediaURL
 		}
 
 		if err := downloadFile(url, destPath); err != nil {
 			output.Error(fmt.Sprintf("Failed to download video %d: %s", i+1, err))
 			continue
 		}
 
-		row := []interface{}{i + 1, destPath, r.Seed}
+		row := []interface{}{i + 1, destPath, results[i].Seed}
 		if includeCost {
-			row = append(row, fmt.Sprintf("%.4f", r.Cost))
+			row = append(row, fmt.Sprintf("%.4f", results[i].Cost))
 		}
 		rows = append(rows, row)
 	}

internal/api/types.go

@@ -90,9 +90,9 @@ type AccountResult struct {
 }
 
 type AccountUsage struct {
-	Total     UsagePeriod `json:"total"`
-	Today     UsagePeriod `json:"today"`
-	Last7Days UsagePeriod `json:"last7Days"`
+	Total      UsagePeriod `json:"total"`
+	Today      UsagePeriod `json:"today"`
+	Last7Days  UsagePeriod `json:"last7Days"`
 	Last30Days UsagePeriod `json:"last30Days"`
 }
 
@@ -103,22 +103,22 @@ type UsagePeriod struct {
 
 // VideoInferenceRequest contains fields for the videoInference task type.
 type VideoInferenceRequest struct {
-	TaskType        string            `json:"taskType"`
-	TaskUUID        string            `json:"taskUUID"`
-	Model           string            `json:"model"`
-	PositivePrompt  string            `json:"positivePrompt,omitempty"`
-	NegativePrompt  string            `json:"negativePrompt,omitempty"`
-	Width           int               `json:"width,omitempty"`
-	Height          int               `json:"height,omitempty"`
-	Duration        float64           `json:"duration,omitempty"`
-	Steps           int               `json:"steps,omitempty"`
-	CFGScale        float64           `json:"CFGScale,omitempty"`
-	Seed            int64             `json:"seed,omitempty"`
-	NumberResults   int               `json:"numberResults,omitempty"`
-	OutputFormat    string            `json:"outputFormat,omitempty"`
-	DeliveryMethod  string            `json:"deliveryMethod,omitempty"`
-	FrameImages     []FrameImage      `json:"frameImages,omitempty"`
-	IncludeCost     bool              `json:"includeCost,omitempty"`
+	TaskType       string       `json:"taskType"`
+	TaskUUID       string       `json:"taskUUID"`
+	Model          string       `json:"model"`
+	PositivePrompt string       `json:"positivePrompt,omitempty"`
+	NegativePrompt string       `json:"negativePrompt,omitempty"`
+	Width          int          `json:"width,omitempty"`
+	Height         int          `json:"height,omitempty"`
+	Duration       float64      `json:"duration,omitempty"`
+	Steps          int          `json:"steps,omitempty"`
+	CFGScale       float64      `json:"CFGScale,omitempty"`
+	Seed           int64        `json:"seed,omitempty"`
+	NumberResults  int          `json:"numberResults,omitempty"`
+	OutputFormat   string       `json:"outputFormat,omitempty"`
+	DeliveryMethod string       `json:"deliveryMethod,omitempty"`
+	FrameImages    []FrameImage `json:"frameImages,omitempty"`
+	IncludeCost    bool         `json:"includeCost,omitempty"`
 }
 
 // FrameImage constrains a specific frame with an input image.

internal/config/config.go

@@ -1,6 +1,7 @@
 package config
 
 import (
+	"errors"
 	"fmt"
 	"os"
 	"path/filepath"
@@ -10,18 +11,18 @@ import (
 )
 
 const (
-	DefaultBaseURL    = "https://api.runware.ai/v1"
-	DefaultModel      = "runware:100@1"
-	DefaultWidth      = 1024
-	DefaultHeight     = 1024
-	DefaultSteps      = 28
-	DefaultCFGScale   = 3.5
-	DefaultScheduler  = "euler"
-	DefaultOutputDir  = "./outputs"
-	DefaultOutputFmt  = "png"
-	DefaultFormat     = "table"
-	DefaultEnv        = "production"
-	DefaultMode       = "public"
+	DefaultBaseURL   = "https://api.runware.ai/v1"
+	DefaultModel     = "runware:100@1"
+	DefaultWidth     = 1024
+	DefaultHeight    = 1024
+	DefaultSteps     = 28
+	DefaultCFGScale  = 3.5
+	DefaultScheduler = "euler"
+	DefaultOutputDir = "./outputs"
+	DefaultOutputFmt = "png"
+	DefaultFormat    = "table"
+	DefaultEnv       = "production"
+	DefaultMode      = "public"
 )
 
 // Defaults holds default values for inference commands.
@@ -90,7 +91,8 @@ func Init() error {
 	_ = viper.BindEnv("environment", "RUNWARE_ENV")
 
 	if err := viper.ReadInConfig(); err != nil {
-		if _, ok := err.(viper.ConfigFileNotFoundError); !ok {
+		var notFound viper.ConfigFileNotFoundError
+		if !errors.As(err, &notFound) {
 			return fmt.Errorf("error reading config: %w", err)
 		}
 		// Config file not found is fine — we use defaults

internal/config/config_test.go

@@ -50,10 +50,10 @@ func TestSaveAndLoad(t *testing.T) {
 		},
 		Presets: map[string]Preset{
 			"fast": {
-				Model: "fast-model",
-				Width: 256,
+				Model:  "fast-model",
+				Width:  256,
 				Height: 256,
-				Steps: 1,
+				Steps:  1,
 			},
 		},
 	}
@@ -107,10 +107,10 @@ func TestPresetOperations(t *testing.T) {
 
 	// Save a preset
 	preset := Preset{
-		Model: "test-model",
-		Width: 768,
+		Model:  "test-model",
+		Width:  768,
 		Height: 768,
-		Steps: 20,
+		Steps:  20,
 	}
 	if err := SavePreset("test-preset", preset); err != nil {
 		t.Fatalf("SavePreset() error: %v", err)