fix error handling in poll tests

Author: danmrichards

cmd/video_inference.go

@@ -313,12 +313,12 @@ func runVideoInference(cmd *cobra.Command, args []string) error {
 		rows = append(rows, row)
 	}
 
+	s.Stop()
+
 	if downloadFailures == len(results) {
 		return fmt.Errorf("all %d video downloads failed", len(results))
 	}
 
-	s.Stop()
-
 	if err := output.Print(format, results, headers, rows); err != nil {
 		return err
 	}

internal/api/poll_test.go

@@ -194,12 +194,9 @@ func TestPollResults_ContextCancelled(t *testing.T) {
 		},
 	}
 
-	results, err := PollResults(ctx, client, "uuid", time.Millisecond, false, parseString)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if results != nil {
-		t.Errorf("expected nil results on cancelled context, got %v", results)
+	_, err := PollResults(ctx, client, "uuid", time.Millisecond, false, parseString)
+	if !errors.Is(err, context.Canceled) {
+		t.Fatalf("expected %v, got error: %v", context.Canceled, err)
 	}
 }
 
@@ -211,11 +208,8 @@ func TestPollResults_ContextTimeout(t *testing.T) {
 	// Never return success — mock returns nil indefinitely.
 	client := &mockClient{}
 
-	results, err := PollResults(ctx, client, "uuid", time.Millisecond, false, parseString)
-	if err != nil {
-		t.Fatalf("unexpected error: %v", err)
-	}
-	if results != nil {
-		t.Errorf("expected nil results on timeout, got %v", results)
+	_, err := PollResults(ctx, client, "uuid", time.Millisecond, false, parseString)
+	if !errors.Is(err, context.DeadlineExceeded) {
+		t.Fatalf("expected %v, got error: %v", context.DeadlineExceeded, err)
 	}
 }