fix(upload): hangs indefinitely on download error instead of exiting

[Ryank90]

For: RUN-10704

[Copilot]

Pull request overview

This PR fixes Client.ModelUpload potentially hanging indefinitely when the model upload pipeline emits a non-failed error status (e.g. "error downloading") by treating such statuses as terminal failures and returning an error to the caller.

Changes:

• Treat additional pipeline error statuses (not just "failed") as terminal failures during streamed modelUpload.
• Add unit tests covering "error downloading" with and without an accompanying message.
• Update ModelUploadResult documentation to reflect failure modes beyond "failed".

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
internal/api/client.go	Ends streamed ModelUpload on error-like statuses by surfacing a terminal failure error.
internal/api/upload_test.go	Adds regression tests ensuring "error downloading" terminates the stream and returns an error.
internal/api/types.go	Updates ModelUploadResult comment to reflect error-status failure cases.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: ab2d5b1f-a1dd-4df6-a3f5-45f5f1b701b4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Note

🎁 Summarized by CodeRabbit Free

Your organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}