Change type of SubtitleData.format field to str#86
Open
amadejkastelic wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Tests failed due to #82. I think this is safe to merge. |
MohamedKhairy220
approved these changes
Jul 25, 2024
edo44
approved these changes
Oct 20, 2024
|
any updates? |
hytradebridge
approved these changes
Oct 23, 2024
Contributor
Author
|
You can monkeypatch it like this in your code until (if ever) this gets merged: https://github.com/amadejkastelic/discord-video-embed-bot/blob/develop/bot%2Fintegrations%2Ftiktok%2F__init__.py |
Just wanted to say thank you for this. It's fixed the formatting error for me. Hopefully it'll get merged soon. |
|
can we merge this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubtitleData.format field can also be a string. Here is one such example:
Tested by monkey-patching the lib.