Skip to content

[WIP] Turn Name Resolution 2.0 on by default#2875

Closed
powerboat9 wants to merge 2 commits into
Rust-GCC:masterfrom
powerboat9:nr-2-wip
Closed

[WIP] Turn Name Resolution 2.0 on by default#2875
powerboat9 wants to merge 2 commits into
Rust-GCC:masterfrom
powerboat9:nr-2-wip

Conversation

@powerboat9

Copy link
Copy Markdown
Collaborator

I've managed to get all of the tests passing, although I had to modify a few tests. I should be able to pull out some of the more minor changes into separate pull requests

@powerboat9 powerboat9 force-pushed the nr-2-wip branch 2 times, most recently from 7612f78 to 3402b08 Compare February 27, 2024 18:03
@P-E-P

P-E-P commented Feb 28, 2024

Copy link
Copy Markdown
Member

Is this a follow up to #2796 ?

@powerboat9

Copy link
Copy Markdown
Collaborator Author

Not necessarily, this is just enough to get tests passing for name resolution 2.0 (although GCC 4.8 is still having problems)

@powerboat9

Copy link
Copy Markdown
Collaborator Author

Note that this only touches early resolution

@CohenArthur

Copy link
Copy Markdown
Member

@powerboat9 should this be a draft or is it ready for reviews?

@powerboat9

Copy link
Copy Markdown
Collaborator Author

draft, sorry

@powerboat9 powerboat9 marked this pull request as draft March 1, 2024 15:14
@CohenArthur

Copy link
Copy Markdown
Member

@powerboat9 now that @P-E-P merged his work on glob imports I think this would be a nice thing to focus on - let me know how I can help and if you'd like me to review parts of the PR or work on some stuff

@powerboat9

Copy link
Copy Markdown
Collaborator Author

A lot of this would now be duplicated work, but I've rebased and will start breaking this down into smaller PRs

@philberty

Copy link
Copy Markdown
Member

Forgive me but whats the purpose of this PR at the moment?

@powerboat9

Copy link
Copy Markdown
Collaborator Author

This was an old branch I was using to work on nr2.0 -- I'll close it once I separate out the useful changes into new PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants