Adjust CI to ignore non-rust warnings#3796
Conversation
|
I kinda dislike the idea of batch disabling warning but I fail to find any counter argument. It wouldn't trigger any warning on some rarely modified common files right ? |
What do you mean? |
Grepping rust will trigger only warning on rust-XXX.{cc,h} files or within the rust/libgrust directories, we rarely modify any files outside of those but this wouldn't be checked by the CI script right ? |
Yeah, so it is a bit of a trade-off |
|
I wonder if having our CI use GCC 15 would help much |
|
We don't really care about warning outside of rust anyway. And from my recent experience of rebasing over upstream frequently, I can see how this change is needed as I've had to fixup the expected warning several times for stuff we haven't modified. And you're correct, we should probably use latest GCC as the goal is to fix any issue the compiler may find, so the latest GCC should be more accurate than anything older... |
|
Well fine you convinced me, @powerboat9 could you bump the compiler version to gcc 15 ? |
|
What is missing for getting this one in? If possible, we should merge it before the next bump (I was willing to bump today or tomorrow) |
|
This PR should be done as soon as I can finish bugfixing it -- I had pivoted to trying to upgrade our CI to GCC 15, but it looks like that'll be a bit more involved |
powerboat9
force-pushed
the
fix-ci
branch
2 times, most recently
from
d5910a6 to
d2156d8
Compare
|
TIL |
This should make it easier for us to ignore warnings from outside the rust front end, and therefore make it easier for us to pull from upstream. ChangeLog: * .github/alpine_32bit_log_warnings: Remove lines. * .github/glibcxx_ubuntu64b_log_expected_warnings: Likewise. * .github/log_expected_warnings: Likewise. * .github/workflows/ccpp.yml: Filter out non-rust warnings. * .github/workflows/ccpp32alpine.yml: Likewise and remove redundant command. * .github/safe-grep: New shell script. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
3 participants
This should make it much easier for us to maintain the expected warnings files