gccrs: Lower IdentifierPattern's to_bind to HIR#3811
Merged
CohenArthur merged 1 commit intoJun 9, 2025
Conversation
Polygonalr
force-pushed
the
identifierpattern-subpattern-lower
branch
from
c565e97 to
8f161cd
Compare
gcc/rust/ChangeLog: * hir/rust-ast-lower-pattern.cc: Lower of IdentifierPattern's to_bind to HIR. * hir/rust-hir-dump.cc: Update IdentifierPattern's dump to properly show to_bind's full full properties. Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>
Polygonalr
force-pushed
the
identifierpattern-subpattern-lower
branch
from
8f161cd to
2f020b9
Compare
Collaborator
|
Check out |
CohenArthur
reviewed
Jun 9, 2025
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
this looks good to me! thank you for the work! your commit message is great as well, well done
CohenArthur
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of making compilation of subpatterns (called
to_bindin the code) of IdentifierPattern work.make check-rustpasses locallyclang-formatgcc/testsuite/rust/May be off-topic for this PR, but to those who have more experience with project, I'm currently having issues with
Resolver::TypeCheckContextnot storing the type of the lowered subpattern, which does not allow me to make changes to successfully compile the subpattern. Any advice will be appreciated!