Skip to content

gccrs: Improve HIR dumps for patterns#3827

Merged
philberty merged 1 commit into
Rust-GCC:masterfrom
Polygonalr:hir-pattern-dump
Jun 15, 2025
Merged

gccrs: Improve HIR dumps for patterns#3827
philberty merged 1 commit into
Rust-GCC:masterfrom
Polygonalr:hir-pattern-dump

Conversation

@Polygonalr

Copy link
Copy Markdown
Contributor

Small one to improve HIR debugging for patterns.

gcc/rust/ChangeLog:

	* hir/rust-hir-dump.cc: Change pattern dumps to use visit_field.

Signed-off-by: Yap Zhi Heng <yapzhhg@gmail.com>

@philberty philberty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added this pull request to the merge queue Jun 15, 2025
@github-project-automation github-project-automation Bot moved this to In progress in Project Pineapple Jun 15, 2025
Merged via the queue into Rust-GCC:master with commit 61238e4 Jun 15, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Project Pineapple Jun 15, 2025
@dkm

dkm commented Jun 16, 2025

Copy link
Copy Markdown
Member

Note the changelog should point at the function being modified.

   	* hir/rust-hir-dump.cc (Dump::visit(StructPatternFieldIdentPat), Dump::visit(LetStmt)): Change pattern dumps to use visit_field. 

@Polygonalr Polygonalr deleted the hir-pattern-dump branch August 2, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants