nr2.0: Enable by default#3840
Merged
Merged
Conversation
powerboat9
force-pushed
the
fix-pen-2
branch
2 times, most recently
from
f14c456 to
0462171
Compare
This prioritizes resolution in the language prelude over resolution as a module. gcc/rust/ChangeLog: * resolve/rust-forever-stack.hxx (ForeverStack::resolve_path): Resolve final segments which point to modules. * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::visit): Avoid inserting module names into ribs in the type namespace. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove issue-3315-2.rs. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
gcc/rust/ChangeLog: * lang.opt (frust-name-resolution-2.0): Enable by default. gcc/testsuite/ChangeLog: * rust/compile/nr2/compile.exp: Removed. * rust/compile/nr2/exclude: Removed. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
Collaborator
Author
|
@P-E-P @CohenArthur @philberty This should be ready to merge |
Member
|
This is kind of exciting and very scary all at the same time I am happy with it but this needs to come from @CohenArthur to merge it. Once its merged we really need a MR to remove the old one having all that old code hanging around will be really annoying. |
CohenArthur
approved these changes
Jul 2, 2025
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
LGTM!!! this is so cool :D I agree with Philip, a subsequent PR should be the removal of the old one + the removal of the flag + all of the checks around the flag. well done @powerboat9 you did some great work
Collaborator
Author
|
Thank you |
P-E-P
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on a few other PRs, but when merged should switch us over to nr2.0 by default