Skip to content

Implement default HIR visitor class#3854

Merged
P-E-P merged 1 commit into
Rust-GCC:masterfrom
sakupan102:default-hir-visitor
Jun 25, 2025
Merged

Implement default HIR visitor class#3854
P-E-P merged 1 commit into
Rust-GCC:masterfrom
sakupan102:default-hir-visitor

Conversation

@sakupan102

@sakupan102 sakupan102 commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor 
gcc/rust/ChangeLog:

	* Make-lang.in: Scaffolding new rust-hir-visitor files
	* hir/tree/rust-hir-visitor.h (class DefaultHIRVisitor): Declare default HIR visitor
	* hir/tree/rust-hir-visitor.cc: Define default HIR visitor

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

philberty
philberty approved these changes Jun 23, 2025
View reviewed changes

@philberty philberty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added the HIR label Jun 23, 2025
@github-project-automation github-project-automation Bot moved this to In progress in Project Pineapple Jun 23, 2025
@philberty philberty removed this from libcore 1.49 Jun 23, 2025
@powerboat9

powerboat9 commented Jun 23, 2025

Copy link
Copy Markdown
Collaborator

@sakupan102 looks like some recent function renames broke a visitor -- should be a small fix

a99e869 for reference

@sakupan102 sakupan102 force-pushed the default-hir-visitor branch 3 times, most recently from 46608d0 to a808c52 Compare June 24, 2025 05:03
@dkm

dkm commented Jun 24, 2025

Copy link
Copy Markdown
Member

The changelog should point at item being modified.

	* Make-lang.in (GRS_OBJS): Scaffolding new rust-hir-visitor files.
	* hir/tree/rust-hir-visitor.h (DefaultHIRVisitor): New.
	* hir/tree/rust-hir-visitor.cc (DefaultHIRVisitor): Likewise.

@sakupan102 sakupan102 force-pushed the default-hir-visitor branch from a808c52 to 04855ce Compare June 24, 2025 13:05
P-E-P
P-E-P reviewed Jun 24, 2025
View reviewed changes

@P-E-P P-E-P left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this looks good.

Comment thread gcc/rust/hir/tree/rust-hir-visitor.cc Outdated
Comment thread gcc/rust/hir/tree/rust-hir-visitor.cc Outdated
@sakupan102
gccrs: Implement default HIR visitor class
76f21e3 
gcc/rust/ChangeLog:

	* Make-lang.in: Scaffolding new rust-hir-visitor files
	* hir/tree/rust-hir-visitor.h (DefaultHIRVisitor): Declare default HIR visitor
	* hir/tree/rust-hir-visitor.cc  (DefaultHIRVisitor): Define default HIR visitor

Signed-off-by: Ryutaro Okada <1015ryu88@gmail.com>
@sakupan102 sakupan102 force-pushed the default-hir-visitor branch from 04855ce to 76f21e3 Compare June 25, 2025 03:58
@sakupan102 sakupan102 requested a review from P-E-P June 25, 2025 03:59
@P-E-P P-E-P added this pull request to the merge queue Jun 25, 2025
Merged via the queue into Rust-GCC:master with commit 6ff5c9a Jun 25, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Project Pineapple Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philberty philberty philberty approved these changes
@P-E-P P-E-P Awaiting requested review from P-E-P

Assignees

No one assigned

Labels

HIR

Projects

Project Pineapple
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sakupan102 @powerboat9 @dkm @philberty @P-E-P