Skip to content

Add getter for non const lifetime object#3857

Merged
philberty merged 1 commit into
Rust-GCC:masterfrom
sakupan102:lifetime-getter
Jun 25, 2025
Merged

Add getter for non const lifetime object#3857
philberty merged 1 commit into
Rust-GCC:masterfrom
sakupan102:lifetime-getter

Conversation

@sakupan102

@sakupan102 sakupan102 commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Since SelfParam has a lifetime but there was no way to obtain it as a non-const object, I added a method to do so.

gcc/rust/ChangeLog:

	* hir/tree/rust-hir-item.h (SelfParam::get_lifetime): Add getter for non const lifetime object

@sakupan102 sakupan102 changed the title gccrs: Add getter for non const lifetime object Add getter for non const lifetime object Jun 24, 2025
@dkm

dkm commented Jun 24, 2025

Copy link
Copy Markdown
Member

The changelog should point at the item being modified, not only the file. Something like:

	* hir/tree/rust-hir-item.h  (SelfParam::get_lifetime): Add getter for non const lifetime object.

gcc/rust/ChangeLog:

	* hir/tree/rust-hir-item.h (SelfParam::get_lifetime): Add getter
	for non const lifetime object

Signed-off-by: Ryutaro Okada <1015ryu88@gmail.com>

@philberty philberty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philberty philberty added this pull request to the merge queue Jun 25, 2025
Merged via the queue into Rust-GCC:master with commit 9dffdef Jun 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants