Skip to content

gccrs: Fix ICE when handling bad constructor#3901

Merged
philberty merged 1 commit into
masterfrom
phil/ty-ice
Jul 10, 2025
Merged

gccrs: Fix ICE when handling bad constructor#3901
philberty merged 1 commit into
masterfrom
phil/ty-ice

Conversation

@philberty

Copy link
Copy Markdown
Member

We just had a typo returning ok true when it should have been false.

Fixes #3876

gcc/rust/ChangeLog:

* typecheck/rust-hir-type-check-struct.cc (TypeCheckStructExpr::visit): fix typo

gcc/testsuite/ChangeLog:

* rust/compile/issue-3876.rs: New test.

We just had a typo returning ok true when it should have been false.

Fixes #3876

gcc/rust/ChangeLog:

	* typecheck/rust-hir-type-check-struct.cc (TypeCheckStructExpr::visit): fix typo

gcc/testsuite/ChangeLog:

	* rust/compile/issue-3876.rs: New test.

Signed-off-by: Philip Herron <herron.philip@googlemail.com>
@philberty philberty enabled auto-merge July 10, 2025 22:11
@philberty philberty added this pull request to the merge queue Jul 10, 2025
auto-merge was automatically disabled July 10, 2025 22:55

Pull Request is not mergeable

Merged via the queue into master with commit bc2a3e6 Jul 10, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in libcore 1.49 Jul 10, 2025
@philberty philberty deleted the phil/ty-ice branch July 11, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

ICE in insert_type, at rust/typecheck/rust-typecheck-context.cc:86

1 participant