Skip to content

Handle IfLetExprConseqElse in DefaultResolver#3996

Merged
CohenArthur merged 1 commit into
Rust-GCC:masterfrom
powerboat9:if-let-conseq
Jul 28, 2025
Merged

Handle IfLetExprConseqElse in DefaultResolver#3996
CohenArthur merged 1 commit into
Rust-GCC:masterfrom
powerboat9:if-let-conseq

Conversation

@powerboat9

Copy link
Copy Markdown
Collaborator

This should fix the CI failure in #3995

This relies on the DefaultASTVisitor visitor for IfLetExprConseqElse
performing a virtual call of the visitor for IfLetExpr, which doesn't
hold when DefaultASTVisitor is generated by the X-macro-DSL-system I
have in another patch.

gcc/rust/ChangeLog:

	* resolve/rust-default-resolver.cc (DefaultResolver::visit): Add
	visitor for IfLetExprConseqElse.
	* resolve/rust-default-resolver.h (DefaultResolver::visit):
	Likewise.

Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>

@philberty philberty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CohenArthur CohenArthur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CohenArthur CohenArthur added this pull request to the merge queue Jul 28, 2025
Merged via the queue into Rust-GCC:master with commit 441d781 Jul 28, 2025
13 checks passed
@powerboat9 powerboat9 deleted the if-let-conseq branch July 28, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants