Fix intrinsic error location

[Jean-Christian-Cirstea]

When an intrisic is used with an incorrect type, prin the location of
the call site, not the declaration.

Fixes #4465.

gcc/rust/ChangeLog:

* backend/rust-intrinsic-handlers.cc: use call site error
location instead of the declaration location

gcc/testsuite/ChangeLog:

* rust/compile/bswap.rs: update error location
* rust/compile/ctlz.rs: update error location
* rust/compile/ctlz_nonzero.rs: update error location
* rust/compile/torture/intrinsics-5.rs: update error location
* rust/compile/torture/intrinsics-7.rs: update error location

[CohenArthur]

The changes look good to me but there are a couple issues with the testsuite where error locations haven't been updated, e.g. rust/compile/torture/intrinsics-5.rs and rust/compile/torture/intrinsics-7.rs. But overall I'm happy with this and once it's fixed I'd like to get it merged :) Thank you!

[dkm]

👋
small nit... But the changelog is not correct:

	* backend/rust-intrinsic-handlers.cc: use call site error
	location instead of the declaration location

It's supposed to be:

   * file (item, item, item): Bla.

you should have the list of all modified functions. The helper script should correctly provide you with a sensible skeleton.
Let us know if you have any issue with this :)

[Jean-Christian-Cirstea]

@dkm Could you please check the commit changelog and tell me if there are any other issues with it?
@CohenArthur @P-E-P Could you take another look at the PR? I have included the cttz intrinsic that was added after the PR was originally created. Thank you!

[dkm]

@dkm Could you please check the commit changelog and tell me if there are any other issues with it? @CohenArthur @P-E-P Could you take another look at the PR? I have included the cttz intrinsic that was added after the PR was originally created. Thank you!

Yes, looks better thanks! Small comments though...

You can group things like:

   * file.c (bla1, bla2, bla3)
   (bla4, bla5) : Toto.
   * file2.cc (foo): Likewise.

And the idiomatic way of not copy/pasting the same text is to use Likewise..

And last one, you should end entries with a . :)

Thanks!

[Jean-Christian-Cirstea]

@dkm Updated the commit message.

[P-E-P]

It looks great! Thank you!