[dropck] Emit Drop Error Codes#4515
Draft
Islam-Imad wants to merge 1 commit into
Draft
Conversation
Islam-Imad
force-pushed
the
EmitDropErrors
branch
from
c3891a7 to
e56a89d
Compare
added some utilites to catch drop related error codes. gcc/rust/ChangeLog: * Make-lang.in: add rust-drop-check.h * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): drop call error * typecheck/rust-hir-type-check-item.cc (TypeCheckItem::visit): union&trait errors * typecheck/rust-hir-type-check.h: peek_trait_impl_map * typecheck/rust-typecheck-context.cc (TypeCheckContext::insert_associated_impl_mapping): peek_trait_impl_map * util/rust-lang-item.cc: add Drop * util/rust-lang-item.h: add Drop * typecheck/rust-drop-check.cc: handle drop logic. * typecheck/rust-drop-check.h: handle drop logic. gcc/testsuite/ChangeLog: * rust/compile/dropck-e0040-direct-drop.rs: New test. * rust/compile/dropck-e0184-copy-drop.rs: New test. * rust/compile/dropck-e0740-union.rs: New test. Signed-off-by: Islam-Imad <islamimad404@gmail.com>
Islam-Imad
force-pushed
the
EmitDropErrors
branch
from
e56a89d to
6e0c9bc
Compare
Member
|
Hi! while having a look at the changelog, I think it may need some adjustment. For example: doesn't really help in knowing what happened in these files. The names are off, I think. Can you respin the changelog part? I looks like you probably did it during an earlier phase of your dev. |
Contributor
Author
|
didn't forget you. a little bit busy nowadays |
Member
|
@Islam-Imad I will put the PR in Draft mode for now, and you can mark it as ready once you are ready for a review again :) |
CohenArthur
added
the
drop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emit :