Limit globbing visitor#4569
Merged
Merged
Conversation
The globbing visitor would previously descend into some kinds of rust item, instead of registering them as glob imports or ignoring them. This would cause items nested in those items to be glob imported, despite them not being top level items inside the glob container. gcc/rust/ChangeLog: * resolve/rust-finalize-imports-2.0.cc (GlobbingVisitor::visit): Add overrides for more items. * resolve/rust-finalize-imports-2.0.h (GlobbingVisitor::visit): Likewise. gcc/testsuite/ChangeLog: * rust/compile/name_resolution27.rs: New test. Reported-by: Arthur Cohen <arthur.cohen@embecosm.com> Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
CohenArthur
approved these changes
Jun 2, 2026
CohenArthur
left a comment
CohenArthur
left a comment
Member
There was a problem hiding this comment.
well done on the fix! thanks!
Member
|
Tested on my branch with |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The globbing visitor would previously descend into some kinds of rust item, instead of registering them as glob imports or ignoring them. This would cause items nested in those items to be glob imported, despite them not being top level items inside the glob container.
Kudos to @CohenArthur for finding this bug.