Omitting revision when specifying `spirv-std` dep

[schell]

cargo-gpu fails to compile my shader crate if my Cargo.toml contains this dep:

[patch.crates-io]
spirv-std = { git = "https://github.com/Rust-GPU/rust-gpu" }

It fails with this error:

[2025-06-14T07:04:35Z ERROR cargo_gpu] get_rust_gpu_deps_from_shader
    
    Caused by:
        Failed to parse git url git+https://github.com/Rust-GPU/rust-gpu#30024f86419f06436c25e835cb4794e1f41fbcb9
Error: get_rust_gpu_deps_from_shader

...but it succeeds (or at least it gets further in my case) with this dep:

[patch.crates-io]
spirv-std = { git = "https://github.com/Rust-GPU/rust-gpu", rev = "30024f8" }

[schell]

It's kind of interesting, the next error after specifying the revision is this:

❯ cargo gpu build --shader-crate crates/tatch
🦀 Compiling shaders at /Users/schell/code/tatch/crates/tatch...
   Compiling compiler_builtins v0.1.138
   Compiling core v0.0.0 (/Users/schell/.rustup/toolchains/nightly-2024-11-22-aarch64-apple-darwin/lib/rustlib/src/rust/library/core)
   Compiling proc-macro2 v1.0.93
   Compiling unicode-ident v1.0.16
   Compiling libm v0.2.11
   Compiling autocfg v1.4.0
   Compiling spirv-std-types v0.9.0 (https://github.com/Rust-GPU/rust-gpu?rev=30024f8#30024f86)
   Compiling spirv-std-types v0.9.0 (https://github.com/Rust-GPU/rust-gpu#30024f86)
   Compiling num-traits v0.2.19
   Compiling quote v1.0.38
   Compiling syn v2.0.98
   Compiling spirv-std-macros v0.9.0 (https://github.com/Rust-GPU/rust-gpu?rev=30024f8#30024f86)
   Compiling crabslab-derive v0.4.3
   Compiling spirv-std-macros v0.9.0 (https://github.com/Rust-GPU/rust-gpu#30024f86)
   Compiling rustc-std-workspace-core v1.99.0 (/Users/schell/.rustup/toolchains/nightly-2024-11-22-aarch64-apple-darwin/lib/rustlib/src/rust/library/rustc-std-workspace-core)
   Compiling bitflags v1.3.2
   Compiling glam v0.29.2
   Compiling spirv-std v0.9.0 (https://github.com/Rust-GPU/rust-gpu?rev=30024f8#30024f86)
   Compiling spirv-std v0.9.0 (https://github.com/Rust-GPU/rust-gpu#30024f86)
   Compiling crabslab v0.6.3
   Compiling tatch v0.1.0 (/Users/schell/code/tatch/crates/tatch)
error[E0152]: duplicate lang item in crate `spirv_std` (which `tatch` depends on): `panic_impl`
  |
  = note: the lang item is first defined in crate `spirv_std` (which `crabslab` depends on)
  = note: first definition in `spirv_std` loaded from /Users/schell/code/tatch/target/spirv-unknown-vulkan1.2/release/deps/libspirv_std-6d8a27457acea6e0.rlib, /Users/schell/code/tatch/target/spirv-unknown-vulkan1.2/release/deps/libspirv_std-6d8a27457acea6e0.rmeta
  = note: second definition in `spirv_std` loaded from /Users/schell/code/tatch/target/spirv-unknown-vulkan1.2/release/deps/libspirv_std-26379bdc47d1b77d.rlib

For more information about this error, try `rustc --explain E0152`.
error: could not compile `tatch` (lib) due to 1 previous error
[2025-06-14T07:09:30Z ERROR cargo_gpu] build failed
Error: build failed

It's interesting because it's compiling two versions of spirv-std, even though they're the same revision:

   Compiling spirv-std v0.9.0 (https://github.com/Rust-GPU/rust-gpu?rev=30024f8#30024f86)
   Compiling spirv-std v0.9.0 (https://github.com/Rust-GPU/rust-gpu#30024f86)

I'm not sure where this bug is creeping in...

[schell]

More interesting, at least to me, is that if the dep spec in [workspace.dependencies] matches the [patch.crates-io], it compiles (so long as I provide a revision):

[workspace.dependencies]
bytemuck = "1.21.0"
craballoc = { version = "0.1" }
crabslab = { version = "0.6.2", default-features = false, features = ["glam"] }
env_logger = "0.10.0"
glam = { version = "0.29", default-features = false }
image = "0.25"
log = "0.4"
pretty_assertions = "1.4.0"
rustc-hash = "1.1"
serde_json = "1.0.117"
spirv-std = { git = "https://github.com/Rust-GPU/rust-gpu", rev = "30024f8" }
snafu = "0.7"
winit = { version = "0.30" }
wgpu = "24.0" 

[patch.crates-io]
spirv-std = { git = "https://github.com/Rust-GPU/rust-gpu", rev = "30024f8" }

But if they do not match, I get the error in my previous comment.

The workaround is to simply have the two match.

[Firestar99]

fixed in #80 commit cf1a585

fix git parsing with no ? in url

[schell]

Thanks @Firestar99 !