This repository was archived by the owner on Apr 15, 2026. It is now read-only.
fix: cargo build/install -p resolves target to shader crate#122
Merged
Conversation
Collaborator
Author
|
@tombh it looks like maybe the tests are failing on an old dependency - is this another case where we need to run |
Collaborator
|
Here's the error, it's the same for both the 0.8.0 and 0.9.0 job failures: But I notice that our lockfile has: [[package]]
name = "indexmap"
version = "2.6.0"So I can't remember why those old builds might be skipping the lockfile 🤔 |
Member
|
see #123 |
Firestar99
approved these changes
Oct 31, 2025
Member
Firestar99
left a comment
There was a problem hiding this comment.
Looks good, just one minor performance thing
c3f1b51 to
fe9047f
Compare
Member
|
Let's merge it as is, even with failing CI. I assume it is ready to review since you asked for one from me, even though the PR itself is still set to WIP. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix #121 by separating
--package/-pfrom--shader-crateargs and performing a lookup usingcargo_metadatato resolve the package name to the shader crate path.Fixes #121.