Conversation
|
Seems like we're resolving to multiple versions of glam between what's re-exported through cust and what's pulled it in directly in some places. We might want to consider using workspace dependencies to ensure we use the same version across our crates. |
|
Yeah, I just did some dumb find and replaces 😄 . I intend to actually look at this in a bit. |
|
I personally think that we don't need vek nor glam for dim1,dim2,dim3 conversion. Mostly users won't use a vek nor a glam vectorized type for creating kernel invocations. To use glam or vek, people should add that as a dependency to their kernel projects instead. |
|
I don't quite know the history, but rust-gpu didn't have it and it was specifically added. There likely was a reason vek was added here as well. |
|
After taking a closer look, I do find the thread/index functions ( |
|
For the record, I do think we should standardize on glam where applicable. It's more broadly used across the ecosystem, and I prefer being able grok a codebase that isn't all macros. |
|
I think ideally we'd have a type or trait in I've also been waiting for externally implementable items to land, as maybe we just define our own trait and let end-user code plug into it, similar to allocators and panic handlers. |
|
I have a branch of this on my fork that's rebased on main and update to fix the remaining errors. |
|
Cool, I can close this one out. Sorry, have had some personal stuff I've had to deal with lately so I've been a bit busy. Hoping it gets cleared up at the start of May! |
|
Oh whoops @jorge-ortega , misread and thought you landed it ha. Is it ready to land, do you want to finish it if not, or shall I cherry-pick here and finish it? |
This fixes #179.