Merged
Conversation
- Don't do Windows CI on forks. (We already don't do Linux CI on forks.) - Don't do container image CI on forks. (We shouldn't be pushing container images to ghcr.io from forks!) - Remove the `if` condition in `deploy_guide.yml`. It has no effct because there is an `on: push: branches: - main` condition higher up doing the same thing (and in the more typical way).
Collaborator
Author
|
The CI failure is the following. I saw the same thing in #267, so I think it's unrelated to this PR. |
Contributor
|
Yeah, that is an intermittent failure where sometimes github actions runs before the entire image or something is downloaded? Or maybe it is a race condition related to the duplicate output warning? I haven't investigated what is going on, but it usually goes away on the rebuild. It weirdly only affects the arm64 jobs. |
nnethercote
added a commit
to nnethercote/Rust-CUDA
that referenced
this pull request
Sep 16, 2025
- Don't do container image CI on forks. (We shouldn't be pushing container images to ghcr.io from forks!) - Remove the `if` condition in `deploy_guide.yml`. It has no effct because there is an `on: push: branches: - main` condition higher up doing the same thing (and in the more typical way). (These changes were supposed to be in Rust-GPU#268, but I failed to commit the changes before pushing, sigh.)
LegNeato
pushed a commit
that referenced
this pull request
Sep 17, 2025
- Don't do container image CI on forks. (We shouldn't be pushing container images to ghcr.io from forks!) - Remove the `if` condition in `deploy_guide.yml`. It has no effct because there is an `on: push: branches: - main` condition higher up doing the same thing (and in the more typical way). (These changes were supposed to be in #268, but I failed to commit the changes before pushing, sigh.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't do Windows CI on forks. (We already don't do Linux CI on forks.)
Don't do container image CI on forks. (We shouldn't be pushing container images to ghcr.io from forks!)
Remove the
ifcondition indeploy_guide.yml. It has no effect because there is anon: push: branches: - maincondition higher up doing the same thing (and in the more typical way).