Skip to content

Fixed 'is_i128', making it check if the type is an intiger, before casting it to check the intiger bit width #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LegNeato merged 2 commits into from
Sep 19, 2025
Merged

Fixed 'is_i128', making it check if the type is an intiger, before casting it to check the intiger bit width #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c921b9
Fixed 'is_i128', making it check if the type is an intiger, before ca…
FractalFir Sep 18, 2025
3404a84
Make int_width only operate on ints
LegNeato Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/rustc_codegen_nvvm/src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,11 @@ impl<'a, 'll, 'tcx> Builder<'a, 'll, 'tcx> {
// Helper function to check if a value is 128-bit integer
fn is_i128(&self, val: &'ll Value) -> bool {
let ty = self.val_ty(val);
unsafe { llvm::LLVMGetIntTypeWidth(ty) == 128 }
if unsafe { llvm::LLVMRustGetTypeKind(ty) == llvm::TypeKind::Integer } {
unsafe { llvm::LLVMGetIntTypeWidth(ty) == 128 }
} else {
false
}
}

// Helper to split i128 into low and high u64 parts
Expand Down
5 changes: 4 additions & 1 deletion crates/rustc_codegen_nvvm/src/ty.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,10 @@ impl<'ll, 'tcx> BaseTypeCodegenMethods for CodegenCx<'ll, 'tcx> {
}

fn int_width(&self, ty: &'ll Type) -> u64 {
unsafe { llvm::LLVMGetIntTypeWidth(ty) as u64 }
match self.type_kind(ty) {
TypeKind::Integer => unsafe { llvm::LLVMGetIntTypeWidth(ty) as u64 },
_ => bug!("llvm_int_width called on a non-integer type"),
}
}

fn val_ty(&self, v: &'ll Value) -> &'ll Type {
Expand Down
Loading