Merged
Conversation
Contributor
Author
|
@nnethercote this changes |
Contributor
Author
|
@nnethercote I am going to rebase this on your macro changes, they look better. |
LegNeato
force-pushed
the
fix128
branch
2 times, most recently
from
ffad7d1 to
e01ffb6
Compare
Contributor
Author
|
I'm still not sure this is right, as I would expect to be using |
This comment was marked as outdated.
This comment was marked as outdated.
LegNeato
force-pushed
the
fix128
branch
2 times, most recently
from
c39901e to
509d28f
Compare
I thought we could use the fallback code from compiler-builtins but I guess not? Most things were broken. I had AI bang out our implementations, I did not write them. This is generating a lot of code, perhaps better to generate a fn and then have everything call it? I added an example and confirmed it works / passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought we could use the fallback code from compiler-builtins but I guess not? Most things were broken....I got confused as to what was provided by whom.
I had AI bang out our implementations, I did not write them.
This is generating a lot of code, perhaps better to generate a fn and then have everything call it?
I added an example and confirmed it works / passes.