Merged
Conversation
- `BuilderMethods::dynamic_alloca` was removed.
- `AddressSpace::DATA` was renamed `AddressSpace::ZERO`.
- `GlobalAlloc` has a new variant `TypeId` which must be handled in
`scalar_to_backend`; I just copied what the llvm backend does.
- `TargetDataLayout::pointer_{size,align}` were changed from fields to
methods.
- `TargetDataLayout::parse_from_llvm_datalayout_string` gained a second
argument.
- Need to create `dcx` in `back::codegen` instead of passing it in.
- LTO changes from rust-lang/rust PR 143388 and PR 144062:
- `run_fat_lto`, `optimize_fat`, and `autodiff` were merged into
`run_and_optimize_fat_lto`, and the parameters were changed.
- `run_thin_lto` parameters were changed.
- `codegen` parameters were changed.
- `LtoModuleCodegen` was removed.
- Some `TypeMembershipCodegenMethods` methods changed arguments from
`String` to `&[u8]`.
- Need to update `target_feature_base_cc.stderr` for an innocuous
looking DWARF `.loc` entry change.
LegNeato
approved these changes
Oct 10, 2025
Contributor
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Looks great, thanks! I appreciate the bullet points saying what changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did this in two steps. Details in individual commits.