change LLVMBuildPointerCast to LLVMBuildAddrSpaceCast#289
Merged
FractalFir merged 1 commit intoRust-GPU:mainfrom Oct 14, 2025
Conversation
Contributor
|
Thanks for the PR, and welcome to the project! 🍻 . I'll let @FractalFir review as he is mroe familiar with this stuff. |
Collaborator
|
The code looks fine to me. Merging. |
PMQ9
deleted the
bugfix/issue_264_casting_between_address_space_using_bitcasts_is_undefined_behavior
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Explained in this issue:
#264
Changes Made
Fixed undefined behavior where
LLVMBuildPointerCastandLLVMBuildBitCastwere being used to change pointer address spaces.Modified two locations in
builder.rs:alloca()method: Now usesLLVMBuildAddrSpaceCastwhen address spaces differpointercast()method: Detects address space changes and routes to the correct cast instructionAll other bitcast/pointer cast uses in the codebase lgtm (either already handle address spaces correctly or don't change address spaces).
Test:
cargo fmt --all -- --check-> passescargo clippy -p rustc_codegen_nvvm-> passesNote: Some GPU kernel examples (
vecadd,gemm,sha2_crates_io) fail during workspace compilation due to runtime DLL loading issues on Windows (unrelated to these changes). Mentioned in:.github/workflows/ci_windows.yml:104.