Merged
Conversation
Four functions we use changed type signature in CUDA 13.0. This commit adds a cfg for each one and then uses conditional compilation at each call site so that the call works for both 12.x and 13.0.
Closed
LegNeato
requested changes
Nov 23, 2025
Contributor
LegNeato
left a comment
LegNeato
left a comment
There was a problem hiding this comment.
Can we get 13 added to CI to make sure this works? It should be a matter of copying the 12 ones, changing the base image, adding to the yaml. If you'd prefer to not include that in this diff, that's fine.
Collaborator
Author
CUDA 13 doesn't work yet. There is one more change I need to make so that the So I think this can be merged as is. |
LegNeato
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four functions we use changed type signature in CUDA 13.0. This commit adds a cfg for each one and then uses conditional compilation at each call site so that the call works for both 12.x and 13.0.