Skip to content

Commit a248d59

Browse files
committed
ci: fix prep cache being useless due to weird feature selection
1 parent 056199e commit a248d59

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

.github/workflows/ci.yaml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,15 @@ jobs:
7878
OUT_DIR: "target/debug/ci/out"
7979
run: cargo run -p example-runner-wgpu-builder --no-default-features --features "use-installed-tools"
8080

81-
- name: prep cache for compiletest and difftest
82-
run: cargo build -p compiletests -p difftests --release --no-default-features --features "use-installed-tools"
81+
- name: prep cache for other jobs
82+
run: |
83+
# they select very different features for dependencies, so they need to be two separate commands
84+
# specifically:
85+
# * compiletests depends on `rustc_codegen_spirv` directly with features `use-installed-tools`
86+
cargo build -p compiletests --release --no-default-features --features "use-installed-tools"
87+
# * difftests depends on `spirv-builder` with no features, which excludes `rustc_codegen_spirv` entirely.
88+
# The individual difftest crates depend on it and run the compile, never the test runner itself.
89+
cargo build -p difftests --release --no-default-features --features "use-installed-tools"
8390

8491

8592
android:

0 commit comments

Comments
 (0)