Skip to content

Add query_size_lod and query_size methods to SampledImage#281

Merged
LegNeato merged 3 commits intoRust-GPU:mainfrom
LegNeato:issue190
Jun 12, 2025
Merged

Add query_size_lod and query_size methods to SampledImage#281
LegNeato merged 3 commits intoRust-GPU:mainfrom
LegNeato:issue190

Conversation

@LegNeato
Copy link
Copy Markdown
Collaborator

@LegNeato LegNeato commented Jun 12, 2025 •
edited
Loading

  • Add query_size_lod for non-multisampled sampled images (Sampled=1)
  • Add query_size for multisampled sampled images
  • Add missing HasQuerySize trait implementations for Sampled::Yes
  • Add compiletests for both methods

Fixes #190

@LegNeato
Add query_size_lod and query_size methods to SampledImage
82ddb0d 
- Add query_size_lod for non-multisampled sampled images (Sampled=1)
- Add query_size for multisampled sampled images
- Add missing HasQuerySize trait implementations for Sampled::Yes
- Add tests for both methods
@LegNeato
Copy link
Copy Markdown
Collaborator Author

LegNeato commented Jun 12, 2025

I used this in a shader and it worked.

@LegNeato
Add ImageSizeQuery
9075508 
Without this cubemaps were broken...we were returning UVec3 but spirv
validation required UVec2.
@LegNeato
Copy link
Copy Markdown
Collaborator Author

LegNeato commented Jun 12, 2025

This was broken for cubemaps, pushed a new commit.

Firestar99
Firestar99 approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Firestar99 Firestar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, didn't check the new impl against spec, I'll just assume compiletests would have caught it.

You're missing compiletest for 1D+arrayed, 3d arrayed and buffer images. (And rect images but those are illegal in vulkan iirc, so who cares)

@LegNeato LegNeato enabled auto-merge June 12, 2025 12:33
@LegNeato LegNeato added this pull request to the merge queue Jun 12, 2025
auto-merge was automatically disabled June 12, 2025 12:52

Pull Request is not mergeable

Merged via the queue into Rust-GPU:main with commit 4f3096a Jun 12, 2025
@LegNeato LegNeato deleted the issue190 branch June 12, 2025 13:03
@Firestar99
Copy link
Copy Markdown
Member

Firestar99 commented Jun 12, 2025

@LegNeato how did this merge into main if the run failed?
https://github.com/Rust-GPU/rust-gpu/actions/runs/15610911293

@LegNeato
Copy link
Copy Markdown
Collaborator Author

LegNeato commented Jun 12, 2025

@Firestar99 No clue! I think it is a github bug because it also seemed to have dropped my updated amended commit that fixed the CI?

@Firestar99 Firestar99 mentioned this pull request Jun 12, 2025
Merged
@nazar-pc
Copy link
Copy Markdown
Contributor

nazar-pc commented Jun 26, 2025 •
edited
Loading

@LegNeato how did this merge into main if the run failed? https://github.com/Rust-GPU/rust-gpu/actions/runs/15610911293

You've probably hit https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks

The fix is to add if: ${{ always() }} to test_success job.

This happens over and over again, and GitHub engineers do not seem to care enough to fix it, offering an obscure workaround instead.

@nazar-pc nazar-pc mentioned this pull request Jun 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Firestar99 Firestar99 Firestar99 approved these changes

@eddyb eddyb Awaiting requested review from eddyb eddyb is a code owner

@schell schell Awaiting requested review from schell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Combined image sampler texture size

3 participants

@LegNeato @Firestar99 @nazar-pc