Fix invalid ArrayStride decorations on arrays in function/private storage#297
Closed
LegNeato wants to merge 1 commit intoRust-GPU:mainfrom
Closed
Fix invalid ArrayStride decorations on arrays in function/private storage#297LegNeato wants to merge 1 commit intoRust-GPU:mainfrom
LegNeato wants to merge 1 commit intoRust-GPU:mainfrom
Conversation
…rage Arrays now track stride as Option<u32> to distinguish between arrays that need explicit layout decorations and those that don't. Arrays with None stride won't have ArrayStride decoration applied. In SPIR-V 1.5+, ArrayStride decorations are only valid for Uniform, StorageBuffer, and PushConstant storage classes. Using them in Function or Private storage is invalid. Fixes Rust-GPU#266
Collaborator
Author
|
@redain can you try this branch and see if it fixes your issue? |
Collaborator
Author
|
Not finished with this, found issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrays now track stride as Option to distinguish between arrays that need explicit layout decorations and those that don't. Arrays with None stride won't have ArrayStride decoration applied.
In SPIR-V 1.5+, ArrayStride decorations are only valid for Uniform, StorageBuffer, and PushConstant storage classes. Using them in Function or Private storage is invalid.
Fixes #266