Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds a pass that does unrolling for loop using profitability model to make sure we only unroll when it's beneficial
you can run the example :
cargo run --example spv-unroll-test examples/spv-unroll-test/shader.spv, shader.spv is based onlib.rsjust to have it as a referenceUnrollConfig::default()was chosen for whatever made sense, if anyone has better default values feel free to change itCurrently only 32/64-bit integers work :
f32 / f64: usesOpFOrdLessThanwhich we don't check for, and float constants need different handling anyway (and floating-point loop bounds aren't statically safe to unroll without exactness guarantees)u16 / u8: these don't exist as SPIR-V scalar types — they're always widened to u32 in shadersNegative i32 bounds return None from
u64_trip_countdue tou32::try_fromoverflow, so the loop will not unroll.