Add ConstKind::Undef (i.e. SPIR-V OpUndef).#37
Draft
eddyb wants to merge 1 commit intoeddyb/output-hermetic-loopsfrom
Draft
Add ConstKind::Undef (i.e. SPIR-V OpUndef).#37eddyb wants to merge 1 commit intoeddyb/output-hermetic-loopsfrom
ConstKind::Undef (i.e. SPIR-V OpUndef).#37eddyb wants to merge 1 commit intoeddyb/output-hermetic-loopsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this PR is a draft to avoid accidental merging onto its "base" branch (used as a form of ad-hoc PR stacking), and will remain as such, until its "base" branch can be set to
main, i.e. all prerequisite PRs will have landed, up to and including this PR (whose branch is the "base" of this one):This would be a a pretty simple addition: a SPIR-T "native" equivalent of SPIR-V
OpUndef/ LLVMundef, mainly simplifying the creation of "filler" constants for dynamically-unused dataflow outputs etc.Except that SPIR-V is moving towards "poison" (including a brand new extension,
SPV_KHR_poison_freeze), following in the footsteps of LLVM - see also:undefvspoisonOne of the places where AFAICT they're willing to be more aggressive than LLVM, is "uninitialized memory" -
OpVariableseems to now default to apoisoninitializer, notundef.It's not unclear at this moment how much of
undef+poisonshould be modeled in SPIR-T, but some could help.