allow warnings in build, error only in ci

Author: Firestar99

.github/workflows/rust-ci.yml

@@ -40,17 +40,24 @@ jobs:
       matrix:
         os: [ ubuntu-latest, macOS-latest ]
         cxx: [ g++, clang++ ]
+        cxxflags: [ '-Werror' ]
+        # msvc's `-Werror` is `/WX`
         include:
           - os: windows-2022
             target: x86_64-pc-windows-msvc
+            cxxflags: '/WX'
           - os: windows-2022
             target: x86_64-pc-windows-msvc
             cxx: clang++
+            cxxflags: '-Werror'
           - os: windows-2022
             target: x86_64-pc-windows-gnu
+            cxxflags: '/WX'
     runs-on: ${{ matrix.os }}
     env:
       CXX: ${{ matrix.cxx }}
+      # error on compiler warnings in CI
+      CXXFLAGS: ${{ matrix.cxxflags }}
     steps:
       - uses: actions/checkout@v4
         with:

spirv-tools-sys/build.rs

@@ -126,7 +126,6 @@ fn main() {
             .flag("-Wno-missing-field-initializers")
             .flag("-Wno-stringop-overflow")
             .flag("-Wno-array-bounds")
-            .flag("-Werror")
             .flag("-std=c++17")
             .flag("-fno-exceptions")
             .flag("-fno-rtti")
@@ -144,7 +143,6 @@ fn main() {
             .flag("-Wnon-virtual-dtor")
             .flag("-Wno-missing-field-initializers")
             .flag("-Wno-self-assign")
-            .flag("-Werror")
             .flag("-std=c++17")
             .flag("-fno-exceptions")
             .flag("-fno-rtti")