Skip to content

Commit b8ac4f5

Browse files
committed
allow warnings in build, error only in ci
1 parent d0e4ead commit b8ac4f5

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/rust-ci.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,17 @@ jobs:
4040
matrix:
4141
os: [ ubuntu-latest, macOS-latest ]
4242
cxx: [ g++, clang++ ]
43+
cxxflags: [ '-Werror' ]
4344
include:
44-
- os: windows-2022
45+
- os: windows-latest
4546
target: x86_64-pc-windows-msvc
47+
# msvc's `-Werror` is `/WX`
48+
cxxflags: '/WX'
4649
runs-on: ${{ matrix.os }}
4750
env:
4851
CXX: ${{ matrix.cxx }}
52+
# error on compiler warnings in CI
53+
CXXFLAGS: ${{ matrix.cxxflags }}
4954
steps:
5055
- uses: actions/checkout@v4
5156
with:

spirv-tools-sys/build.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ fn main() {
126126
.flag("-Wno-missing-field-initializers")
127127
.flag("-Wno-stringop-overflow")
128128
.flag("-Wno-array-bounds")
129-
.flag("-Werror")
130129
.flag("-std=c++17")
131130
.flag("-fno-exceptions")
132131
.flag("-fno-rtti")
@@ -144,7 +143,6 @@ fn main() {
144143
.flag("-Wnon-virtual-dtor")
145144
.flag("-Wno-missing-field-initializers")
146145
.flag("-Wno-self-assign")
147-
.flag("-Werror")
148146
.flag("-std=c++17")
149147
.flag("-fno-exceptions")
150148
.flag("-fno-rtti")

0 commit comments

Comments
 (0)