Skip to content

Commit 5daa3c4

Browse files
rtla/tests: Add unit tests for -A/--aligned option
Add both parse_args() and opt_* tests for the newly added -A/--aligned option. Assisted-by: Claude:claude-4.5-opus-high-thinking Link: https://lore.kernel.org/r/20260527144928.2944472-2-tglozar@redhat.com Signed-off-by: Tomas Glozar <tglozar@redhat.com>
1 parent 03d745b commit 5daa3c4

3 files changed

Lines changed: 52 additions & 0 deletions

File tree

tools/tracing/rtla/tests/unit/cli_opt_callback.c

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -545,6 +545,17 @@ START_TEST(test_opt_nano_cb)
545545
}
546546
END_TEST
547547

548+
START_TEST(test_opt_timerlat_align_cb)
549+
{
550+
struct timerlat_params params = {0};
551+
const struct option opt = TEST_CALLBACK(&params, opt_timerlat_align_cb);
552+
553+
ck_assert_int_eq(opt_timerlat_align_cb(&opt, "500", 0), 0);
554+
ck_assert(params.timerlat_align);
555+
ck_assert_int_eq(params.timerlat_align_us, 500);
556+
}
557+
END_TEST
558+
548559
START_TEST(test_opt_stack_format_cb)
549560
{
550561
int stack_format = 0;
@@ -689,6 +700,7 @@ Suite *cli_opt_callback_suite(void)
689700
tcase_add_test(tc, test_opt_nano_cb);
690701
tcase_add_test(tc, test_opt_stack_format_cb);
691702
tcase_add_exit_test(tc, test_opt_stack_format_cb_invalid, EXIT_FAILURE);
703+
tcase_add_test(tc, test_opt_timerlat_align_cb);
692704
suite_add_tcase(s, tc);
693705

694706
tc = tcase_create("histogram");

tools/tracing/rtla/tests/unit/timerlat_hist_cli.c

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,24 @@ START_TEST(test_user_threads_long)
373373
}
374374
END_TEST
375375

376+
START_TEST(test_aligned_short)
377+
{
378+
PARSE_ARGS("timerlat", "hist", "-A", "500");
379+
380+
ck_assert(tlat_params->timerlat_align);
381+
ck_assert_int_eq(tlat_params->timerlat_align_us, 500);
382+
}
383+
END_TEST
384+
385+
START_TEST(test_aligned_long)
386+
{
387+
PARSE_ARGS("timerlat", "hist", "--aligned", "500");
388+
389+
ck_assert(tlat_params->timerlat_align);
390+
ck_assert_int_eq(tlat_params->timerlat_align_us, 500);
391+
}
392+
END_TEST
393+
376394
/* Histogram Options */
377395

378396
START_TEST(test_bucket_size_short)
@@ -654,6 +672,8 @@ Suite *timerlat_hist_cli_suite(void)
654672
tcase_add_test(tc, test_user_load_long);
655673
tcase_add_test(tc, test_user_threads_short);
656674
tcase_add_test(tc, test_user_threads_long);
675+
tcase_add_test(tc, test_aligned_short);
676+
tcase_add_test(tc, test_aligned_long);
657677
suite_add_tcase(s, tc);
658678

659679
tc = tcase_create("histogram_options");

tools/tracing/rtla/tests/unit/timerlat_top_cli.c

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,24 @@ START_TEST(test_user_threads_long)
373373
}
374374
END_TEST
375375

376+
START_TEST(test_aligned_short)
377+
{
378+
PARSE_ARGS("timerlat", "top", "-A", "500");
379+
380+
ck_assert(tlat_params->timerlat_align);
381+
ck_assert_int_eq(tlat_params->timerlat_align_us, 500);
382+
}
383+
END_TEST
384+
385+
START_TEST(test_aligned_long)
386+
{
387+
PARSE_ARGS("timerlat", "top", "--aligned", "500");
388+
389+
ck_assert(tlat_params->timerlat_align);
390+
ck_assert_int_eq(tlat_params->timerlat_align_us, 500);
391+
}
392+
END_TEST
393+
376394
/* Output */
377395

378396
START_TEST(test_nano_short)
@@ -596,6 +614,8 @@ Suite *timerlat_top_cli_suite(void)
596614
tcase_add_test(tc, test_user_load_long);
597615
tcase_add_test(tc, test_user_threads_short);
598616
tcase_add_test(tc, test_user_threads_long);
617+
tcase_add_test(tc, test_aligned_short);
618+
tcase_add_test(tc, test_aligned_long);
599619
suite_add_tcase(s, tc);
600620

601621
tc = tcase_create("output");

0 commit comments

Comments
 (0)