Skip to content

Commit aad35f9

Browse files
selvarasu-ggregkh
authored andcommitted
usb: dwc3: Move GUID programming after PHY initialization
The Linux Version Code is currently written to the GUID register before PHY initialization. Certain PHY implementations (such as Synopsys eUSB PHY performing link_sw_reset) clear the GUID register to its default value during initialization, causing the kernel version information to be lost. Move the GUID register programming to occur after PHY initialization completes to ensure the Linux version information persists. Fixes: fa0ea13 ("usb: dwc3: core: write LINUX_VERSION_CODE to our GUID register") Cc: stable <stable@kernel.org> Reported-by: Pritam Manohar Sutar <pritam.sutar@samsung.com> Signed-off-by: Selvarasu Ganesan <selvarasu.g@samsung.com> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Link: https://patch.msgid.link/20260417063314.2359-1-selvarasu.g@samsung.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f6ec9bb commit aad35f9

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

drivers/usb/dwc3/core.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1359,12 +1359,6 @@ int dwc3_core_init(struct dwc3 *dwc)
13591359

13601360
hw_mode = DWC3_GHWPARAMS0_MODE(dwc->hwparams.hwparams0);
13611361

1362-
/*
1363-
* Write Linux Version Code to our GUID register so it's easy to figure
1364-
* out which kernel version a bug was found.
1365-
*/
1366-
dwc3_writel(dwc, DWC3_GUID, LINUX_VERSION_CODE);
1367-
13681362
ret = dwc3_phy_setup(dwc);
13691363
if (ret)
13701364
return ret;
@@ -1398,6 +1392,12 @@ int dwc3_core_init(struct dwc3 *dwc)
13981392
if (ret)
13991393
goto err_exit_phy;
14001394

1395+
/*
1396+
* Write Linux Version Code to our GUID register so it's easy to figure
1397+
* out which kernel version a bug was found.
1398+
*/
1399+
dwc3_writel(dwc, DWC3_GUID, LINUX_VERSION_CODE);
1400+
14011401
dwc3_core_setup_global_control(dwc);
14021402
dwc3_core_num_eps(dwc);
14031403

0 commit comments

Comments
 (0)